Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build failed after upgrade golang.org/x/sys #396

Merged
merged 2 commits into from
Sep 19, 2020
Merged

fix build failed after upgrade golang.org/x/sys #396

merged 2 commits into from
Sep 19, 2020

Conversation

akayj
Copy link
Contributor

@akayj akayj commented Sep 19, 2020

After upgrading golang.org/x/sys to latest version, v0.0.0-20200918174421-af09f7315aff for example,
build will failed, because of this
unix.SYS_IOCTL was removed, using syscall.SYS_IOCTL instead.

@akayj
fix build failed after upgrade golang.org/x/sys
7ef85b4 
After upgrading `golang.org/x/sys` to latest version,  `v0.0.0-20200918174421-af09f7315aff` for example,
build will failed, because of [this](golang/sys@6fcdbc0)
@akayj
Update logger_darwin.go
c141f40
evanw
evanw approved these changes Sep 19, 2020
View reviewed changes
Copy link
Owner

@evanw evanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@evanw evanw merged commit 2bdac74 into evanw:master Sep 19, 2020
@evanw
Copy link
Owner

evanw commented Sep 19, 2020

I ended up switching to unix.IoctlGetWinsize instead since it seemed more appropriate and higher-level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanw evanw evanw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akayj @evanw