[Node 8.x] Update docs to reflect new min version #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-native ready! Built with commit 0e0b0b7 https://deploy-preview-355--react-native.netlify.com Changes to Thank you for your contributions. |
elicwhite
approved these changes
May 10, 2018
11 tasks
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
May 12, 2018
Summary: Moving to Node 8 in React Native will allow us to be consistent with Facebook, e.g. trailing commas. As of April 30, Node 4.x is end of life, and Node 6.x entered maintenance mode (see https://medium.com/the-node-js-collection/april-2018-release-updates-from-the-node-js-project-71687e1f7742). This will require our docs to be updated to require Node 8 as a minimum. This should be done as part of the following PR: facebook/react-native-website#355 Circle CI already runs all JS tests using Node 8, and it has an extra compatibility check that uses Node 6. This workflow is dropped as we no longer need to check for failures when Node 6 is used. See #19226 [GENERAL] [BREAKING] [Node] - Bump minimum req. Node version to 8 Closes #19230 Differential Revision: D7979478 Pulled By: hramos fbshipit-source-id: c91ec118f0a59c4daae5fcdbfc822ccead591304
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: Moving to Node 8 in React Native will allow us to be consistent with Facebook, e.g. trailing commas. As of April 30, Node 4.x is end of life, and Node 6.x entered maintenance mode (see https://medium.com/the-node-js-collection/april-2018-release-updates-from-the-node-js-project-71687e1f7742). This will require our docs to be updated to require Node 8 as a minimum. This should be done as part of the following PR: facebook/react-native-website#355 Circle CI already runs all JS tests using Node 8, and it has an extra compatibility check that uses Node 6. This workflow is dropped as we no longer need to check for failures when Node 6 is used. See facebook#19226 [GENERAL] [BREAKING] [Node] - Bump minimum req. Node version to 8 Closes facebook#19230 Differential Revision: D7979478 Pulled By: hramos fbshipit-source-id: c91ec118f0a59c4daae5fcdbfc822ccead591304
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Moving to Node 8 in React Native will allow us to be consistent with Facebook, e.g. trailing commas. As of April 30, Node 4.x is end of life, and Node 6.x entered maintenance mode (see https://medium.com/the-node-js-collection/april-2018-release-updates-from-the-node-js-project-71687e1f7742). This will require our docs to be updated to require Node 8 as a minimum. This should be done as part of the following PR: facebook/react-native-website#355 Circle CI already runs all JS tests using Node 8, and it has an extra compatibility check that uses Node 6. This workflow is dropped as we no longer need to check for failures when Node 6 is used. See facebook/react-native#19226 [GENERAL] [BREAKING] [Node] - Bump minimum req. Node version to 8 Closes facebook/react-native#19230 Differential Revision: D7979478 Pulled By: hramos fbshipit-source-id: c91ec118f0a59c4daae5fcdbfc822ccead591304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to Node 8 in React Native will allow us to be consistent with Facebook, e.g. trailing commas.
As of April 30, Node 4.x is end of life, and Node 6.x entered maintenance mode (see https://medium.com/the-node-js-collection/april-2018-release-updates-from-the-node-js-project-71687e1f7742).