[Node 8] Prepare for Node 8 #19226
Labels
JavaScript
Resolution: Fixed
A PR that fixes this issue has been merged.
Resolution: Locked
This issue was locked by the bot.
Type: Discussion
Long running discussion.
Comments
facebook-github-bot
pushed a commit
that referenced
this issue
May 12, 2018
Summary: Moving to Node 8 in React Native will allow us to be consistent with Facebook, e.g. trailing commas. As of April 30, Node 4.x is end of life, and Node 6.x entered maintenance mode (see https://medium.com/the-node-js-collection/april-2018-release-updates-from-the-node-js-project-71687e1f7742). This will require our docs to be updated to require Node 8 as a minimum. This should be done as part of the following PR: facebook/react-native-website#355 Circle CI already runs all JS tests using Node 8, and it has an extra compatibility check that uses Node 6. This workflow is dropped as we no longer need to check for failures when Node 6 is used. See #19226 [GENERAL] [BREAKING] [Node] - Bump minimum req. Node version to 8 Closes #19230 Differential Revision: D7979478 Pulled By: hramos fbshipit-source-id: c91ec118f0a59c4daae5fcdbfc822ccead591304
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this issue
Jun 28, 2018
Summary: Moving to Node 8 in React Native will allow us to be consistent with Facebook, e.g. trailing commas. As of April 30, Node 4.x is end of life, and Node 6.x entered maintenance mode (see https://medium.com/the-node-js-collection/april-2018-release-updates-from-the-node-js-project-71687e1f7742). This will require our docs to be updated to require Node 8 as a minimum. This should be done as part of the following PR: facebook/react-native-website#355 Circle CI already runs all JS tests using Node 8, and it has an extra compatibility check that uses Node 6. This workflow is dropped as we no longer need to check for failures when Node 6 is used. See facebook#19226 [GENERAL] [BREAKING] [Node] - Bump minimum req. Node version to 8 Closes facebook#19230 Differential Revision: D7979478 Pulled By: hramos fbshipit-source-id: c91ec118f0a59c4daae5fcdbfc822ccead591304
grabbou
pushed a commit
to react-native-community/cli
that referenced
this issue
Sep 26, 2018
Summary: Moving to Node 8 in React Native will allow us to be consistent with Facebook, e.g. trailing commas. As of April 30, Node 4.x is end of life, and Node 6.x entered maintenance mode (see https://medium.com/the-node-js-collection/april-2018-release-updates-from-the-node-js-project-71687e1f7742). This will require our docs to be updated to require Node 8 as a minimum. This should be done as part of the following PR: facebook/react-native-website#355 Circle CI already runs all JS tests using Node 8, and it has an extra compatibility check that uses Node 6. This workflow is dropped as we no longer need to check for failures when Node 6 is used. See facebook/react-native#19226 [GENERAL] [BREAKING] [Node] - Bump minimum req. Node version to 8 Closes facebook/react-native#19230 Differential Revision: D7979478 Pulled By: hramos fbshipit-source-id: c91ec118f0a59c4daae5fcdbfc822ccead591304
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The time has come to bump the minimum required Node version to 8. Node 4.x LTS reached end of life, and Node 6.x entered maintenance mode, on April 30, 2018. Furthermore, this will allow us to be consistent with the rest of the JavaScript code at Facebook.
The codebase is ready for this, as our tests have been running on Node 8 for a while now.
Things that need to be done:
react-native-website/#355)Libraries/tolet/consts(8f5ebe5)local-cli/server/ checkNodeVersion.js).circleci/ config.yml)The last three action items are in flight and should be landing soon.
cc @ide (h/t #2545), @TheSavior, @grabbou
Environment
N/A
Steps to Reproduce
N/A
Expected Behavior
N/A
Actual Behavior
N/A
The text was updated successfully, but these errors were encountered: