Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Node version to 8.3 #20236

Closed
wants to merge 1 commit into from
Closed

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Jul 16, 2018

Node rest/spread syntax started working without the harmony flag in 8.3 (#20178 (comment)).

Release Notes:
[GENERAL] [BREAKING] [Node] - Bump minimum req. Node version to 8.3

Test Plan:

Circle CI

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2018
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jul 17, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was closed by @hramos in e64e13f.

Once this commit is added to a release, you will see the corresponding version tag below the description at e64e13f. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 18, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 18, 2018
@hramos hramos deleted the node-8.3 branch July 19, 2018 01:04
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
Summary:
Node rest/spread syntax started working without the harmony flag in 8.3 (facebook/react-native#20178 (comment)).

Release Notes:
[GENERAL] [BREAKING] [Node] - Bump minimum req. Node version to 8.3
Pull Request resolved: facebook/react-native#20236

Differential Revision: D8876357

Pulled By: hramos

fbshipit-source-id: 1f5f791ef318e70c6be8b23d887a1d650a68e594
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. JavaScript Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants