Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum Node version to 8.3 #20236

Closed
wants to merge 1 commit into from
Closed

Bump minimum Node version to 8.3 #20236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions local-cli/server/checkNodeVersion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var formatBanner = require('metro-core/src/formatBanner');
var semver = require('semver');

module.exports = function() {
if (!semver.satisfies(process.version, '>=8')) {
if (!semver.satisfies(process.version, '>=8.3')) {
var engine = semver.satisfies(process.version, '<1') ? 'Node' : 'io.js';

var message =
Expand All @@ -24,15 +24,12 @@ module.exports = function() {
process.version +
'.\n' +
'\n' +
'React Native runs on Node 8.0 or newer. There are several ways to ' +
'React Native runs on Node 8.3 or newer. There are several ways to ' +
'upgrade Node.js depending on your preference.\n' +
'\n' +
'nvm: nvm install node && nvm alias default node\n' +
'Homebrew: brew unlink iojs; brew install node\n' +
'Installer: download the Mac .pkg from https://nodejs.org/\n' +
'\n' +
'About Node.js: https://nodejs.org\n' +
'Follow along at: https://github.com/facebook/react-native/issues/19226';
'nvm: nvm install 8.3 --reinstall-packages-from=node\n' +
'Homebrew: brew update && brew upgrade node\n' +
'Installer: download from https://nodejs.org/\n';
console.log(
formatBanner(message, {
chalkFunction: chalk.green,
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"url": "git@github.com:facebook/react-native.git"
},
"engines": {
"node": ">=8"
"node": ">=8.3"
},
"prettier": {
"requirePragma": true,
Expand Down