[TM] Add spec for KeyboardObserver #24881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
react-native-bot
added
API: Keyboard
Type: Enhancement
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
rickhanlonii
requested changes
May 17, 2019
There was a problem hiding this comment.
Looks like there are a bunch of flow errors, could you take a look @ericlewis?
|
Yep, this one is pretty weird- it doesn’t seem to have a reason to freak out that bad. Will address today though.
Sent via Superhuman iOS ( https://sprh.mn/?vip=ericlewis777@gmail.com )
…On Fri, May 17 2019 at 7:27 AM, < ***@***.*** > wrote:
***@***.**** requested changes on this pull request.
Looks like there are a bunch of flow errors, could you take a look @ericlewis
( https://github.com/ericlewis ) ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
#24881?email_source=notifications&email_token=AAFEVR4SB6DNA3AK23QDKJLPV2JCJA5CNFSM4HNITTHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBY6OOJQ#pullrequestreview-238872358
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/AAFEVR3KGK2TLSG6VEOXZBLPV2JCJANCNFSM4HNITTHA
).
|
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @ericlewis in 905e3fc. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: part of facebook#24875. iOS only it appears, but not really used by RN itself. Should be fine? ## Changelog [General] [Added] - Add TM spec for KeyboardObserver Pull Request resolved: facebook#24881 Reviewed By: fkgozali Differential Revision: D15391769 Pulled By: rickhanlonii fbshipit-source-id: 557507f6063b40d1c68ec8739e23b33bc22ade39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
part of #24875. iOS only it appears, but not really used by RN itself. Should be fine?
Changelog
[General] [Added] - Add TM spec for KeyboardObserver
Test Plan
Flow passes.