Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TM] Add spec for KeyboardObserver #24881

Closed
wants to merge 5 commits into from
Closed

[TM] Add spec for KeyboardObserver #24881

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8085d3
[TM] Add spec for KeyboardObserver
ericlewis May 16, 2019
d962e54
iOS only
ericlewis May 16, 2019
7728f86
Use get, not getEnforcing
ericlewis May 21, 2019
2bed28c
Merge remote-tracking branch 'upstream/master' into spec-keyboardobse…
ericlewis May 21, 2019
9520e98
Add space
ericlewis May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use get, not getEnforcing
  • Loading branch information
@ericlewis
ericlewis committed May 21, 2019
commit 7728f867f6b0e13356a9d358b103e03e323afbb0
5 changes: 1 addition & 4 deletions Libraries/Components/Keyboard/NativeKeyboardObserver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,10 @@

import type {TurboModule} from 'RCTExport';
import * as TurboModuleRegistry from 'TurboModuleRegistry';
import {Platform} from 'react-native';

export interface Spec extends TurboModule {
+addListener: (eventName: string) => void;
+removeListeners: (count: number) => void;
}

export default (Platform.OS === 'ios'
? TurboModuleRegistry.getEnforcing<Spec>('KeyboardObserver')
: null);
export default TurboModuleRegistry.get<Spec>('KeyboardObserver');