Update on "[compiler] Always error on async reassignments"

Summary: Addresses the issue in #30109: any mutation of a local in an async function may occur after rendering has finished. [ghstack-poisoned]
facebook · Jun 27, 2024 · 5b63533 · 5b63533
2 parents d8fba52 + 7a33e9c
commit 5b63533
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/...ages/babel-plugin-react-compiler/src/Validation/ValidateLocalsNotReassignedAfterRender.ts b/...ages/babel-plugin-react-compiler/src/Validation/ValidateLocalsNotReassignedAfterRender.ts
@@ -19,7 +19,12 @@ import {
  */
 export function validateLocalsNotReassignedAfterRender(fn: HIRFunction): void {
   const contextVariables = new Set<IdentifierId>();
-  const reassignment = getContextReassignment(fn, contextVariables, false, false);
+  const reassignment = getContextReassignment(
+    fn,
+    contextVariables,
+    false,
+    false
+  );
   if (reassignment !== null) {
     CompilerError.throwInvalidReact({
       reason:
@@ -38,7 +43,7 @@ function getContextReassignment(
   fn: HIRFunction,
   contextVariables: Set<IdentifierId>,
   isFunctionExpression: boolean,
-  isAsync: boolean,
+  isAsync: boolean
 ): Place | null {
   const reassigningFunctions = new Map<IdentifierId, Place>();
   for (const [, block] of fn.body.blocks) {
@@ -51,7 +56,7 @@ function getContextReassignment(
             value.loweredFunc.func,
             contextVariables,
             true,
-            isAsync || value.loweredFunc.func.async,
+            isAsync || value.loweredFunc.func.async
           );
           if (reassignment === null) {
             // If the function itself doesn't reassign, does one of its dependencies?

diff --git a/...mpiler/todo.invalid-nested-function-reassign-local-variable-in-effect.expect.md b/...mpiler/todo.invalid-nested-function-reassign-local-variable-in-effect.expect.md
@@ -11,7 +11,7 @@ function Component() {
       local = newValue;
     };
     return reassignLocal;
-  }
+  };
   const reassignLocal = mk_reassignlocal();
   const onMount = (newValue) => {
     reassignLocal("hello");

diff --git a/...sts__/fixtures/compiler/todo.invalid-nested-function-reassign-local-variable-in-effect.js b/...sts__/fixtures/compiler/todo.invalid-nested-function-reassign-local-variable-in-effect.js
@@ -7,7 +7,7 @@ function Component() {
       local = newValue;
     };
     return reassignLocal;
-  }
+  };
   const reassignLocal = mk_reassignlocal();
   const onMount = (newValue) => {
     reassignLocal("hello");