Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Add todo fixtures for local reassignment in an async callback #30109

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[compiler] Add todo fixtures for local reassignment in an async callback #30109

merged 1 commit into from
Jun 26, 2024

Conversation

josephsavona
Copy link
Contributor

@josephsavona josephsavona commented Jun 26, 2024 •
edited
Loading

@josephsavona josephsavona mentioned this pull request Jun 26, 2024
Merged
@vercel Vercel
Copy link

vercel bot commented Jun 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 11:11pm

@josephsavona josephsavona mentioned this pull request Jun 26, 2024
Merged
josephsavona added a commit that referenced this pull request Jun 26, 2024
@josephsavona
[compiler] Add todo fixtures for local reassignment in an async callback
d8438e7 
ghstack-source-id: eca878f62a2149af76a72b59acd1820d0df86f30
Pull Request resolved: #30109
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Jun 26, 2024
@react-sizebot
Copy link

Comparing: ef0f44e...32ef606

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.16% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.16% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.10 kB 597.10 kB = 105.31 kB 105.31 kB
facebook-www/ReactDOM-prod.modern.js = 571.44 kB 571.44 kB = 101.24 kB 101.24 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 32ef606

@josephsavona josephsavona merged commit 32ef606 into gh/josephsavona/34/base Jun 26, 2024
36 checks passed
josephsavona added a commit that referenced this pull request Jun 26, 2024
@josephsavona
[compiler] Add todo fixtures for local reassignment in an async callback
00775d9 
ghstack-source-id: eca878f62a2149af76a72b59acd1820d0df86f30
Pull Request resolved: #30109
@josephsavona josephsavona deleted the gh/josephsavona/34/head branch June 26, 2024 23:51
mvitousek added a commit that referenced this pull request Jun 26, 2024
@mvitousek
[compiler] Always error on async reassignments
d8fba52 
Summary: Addresses the issue in #30109: any mutation of a local in an async function may occur after rendering has finished.

[ghstack-poisoned]
@mvitousek mvitousek mentioned this pull request Jun 26, 2024
Merged
mvitousek added a commit that referenced this pull request Jun 26, 2024
@mvitousek
[compiler] Always error on async reassignments
ee857f0 
Summary: Addresses the issue in #30109: any mutation of a local in an async function may occur after rendering has finished.

ghstack-source-id: 5cf4b1db7ffff2db962d9b1fc3e9b37e10e3dff2
Pull Request resolved: #30111
mvitousek added a commit that referenced this pull request Jun 27, 2024
@mvitousek
Update base for Update on "[compiler] Always error on async reassignm…
7a33e9c 
…ents"

Summary: Addresses the issue in #30109: any mutation of a local in an async function may occur after rendering has finished.

[ghstack-poisoned]
mvitousek added a commit that referenced this pull request Jun 27, 2024
@mvitousek
Update on "[compiler] Always error on async reassignments"
5b63533 
Summary: Addresses the issue in #30109: any mutation of a local in an async function may occur after rendering has finished.

[ghstack-poisoned]
mvitousek added a commit that referenced this pull request Jun 27, 2024
@mvitousek
[compiler] Always error on async reassignments
fcfbfc1 
Summary: Addresses the issue in #30109: any mutation of a local in an async function may occur after rendering has finished.

ghstack-source-id: 9f15cf0f144c0badd6009ceb51df43a50399d82b
Pull Request resolved: #30111
@eps1lon eps1lon mentioned this pull request Jul 16, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvitousek mvitousek mvitousek approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephsavona @react-sizebot @mvitousek @facebook-github-bot