Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Examples of invalid code reassigning locals outside of render #30106

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 10:11pm

@react-sizebot
Copy link

react-sizebot commented Jun 26, 2024

Comparing: ef0f44e...59015bc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.10 kB 597.10 kB = 105.31 kB 105.31 kB
facebook-www/ReactDOM-prod.modern.js = 571.44 kB 571.44 kB = 101.24 kB 101.24 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 59015bc

@josephsavona josephsavona merged commit 59015bc into gh/josephsavona/32/base Jun 26, 2024
36 checks passed
josephsavona added a commit that referenced this pull request Jun 26, 2024
ghstack-source-id: c48d0d0b86e47e2449982263c88cc2cfd44e326b
Pull Request resolved: #30106
@josephsavona josephsavona deleted the gh/josephsavona/32/head branch June 26, 2024 23:51
mvitousek added a commit that referenced this pull request Jun 26, 2024
Summary: Additional repro demonstrating a case that still exists after #30106

[ghstack-poisoned]
mvitousek added a commit that referenced this pull request Jun 27, 2024
…sue"

Summary: Additional repro demonstrating a case that still exists after #30106

[ghstack-poisoned]
mvitousek added a commit that referenced this pull request Jun 27, 2024
Summary: Additional repro demonstrating a case that still exists after #30106

ghstack-source-id: f03176fd88b29098d0263f86c1a7126e214997e5
Pull Request resolved: #30110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants