[compiler] Consume compiled lib in react 18 app #31166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Oct 10, 2024
facebook-github-bot
added
CLA Signed
React Core Team
|
|
|
Comparing: de43d56...db62a06 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
| @@ -11,13 +11,16 @@ | |||
| }, | |||
| "dependencies": { | |||
| "react": "^18.3.1", | |||
| "react-dom": "^18.3.1" | |||
| "react-compiler-runtime": "0.0.0-experimental-8d8e73f-20241009", | |||
There was a problem hiding this comment.
This is only required for the app code, not to make the library work, right? Since the library has its own dependency on the compiler runtime.
josephsavona
approved these changes
Oct 10, 2024
poteto
added a commit
that referenced
this pull request
Oct 10, 2024
Add missing directory to prettierignore. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31168). * #31167 * #31166 * #31165 * #31164 * #31148 * __->__ #31168
poteto
added a commit
that referenced
this pull request
Oct 10, 2024
Scaffolds an empty library to test backwards compatibility with the compiler enabled. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31148). * #31167 * #31166 * #31165 * #31164 * __->__ #31148 * #31168
poteto
added a commit
that referenced
this pull request
Oct 10, 2024
Scaffold empty apps to consume the fixture lib. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31164). * #31167 * #31166 * #31165 * __->__ #31164 * #31148 * #31168
Add and compile a simple hook with rollup and babel.
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address. However `yarn build` and `yarn preview` does work as expected.
poteto
added a commit
that referenced
this pull request
Oct 10, 2024
Add and compile a simple hook with rollup and babel. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31165). * #31167 * #31166 * __->__ #31165
poteto
added a commit
that referenced
this pull request
Oct 10, 2024
it works --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31167). * __->__ #31167 * #31166 * #31165
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn devdoesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a PR open to address.However
yarn buildandyarn previewdoes work as expected.Stack created with Sapling. Best reviewed with ReviewStack.