Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Consume compiled lib in react 18 app #31166

Merged
merged 2 commits into from
Oct 10, 2024
Merged

[compiler] Consume compiled lib in react 18 app #31166

merged 2 commits into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. [compiler] Compile lib 

    Add and compile a simple hook with rollup and babel.
    @poteto
    poteto committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9de5ec2 View commit details
    Browse the repository at this point in the history

  2. [compiler] Consume compiled lib in react 18 app 

    `yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address.

However `yarn build` and `yarn preview` does work as expected.
    @poteto
    poteto committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1d13a5f View commit details
    Browse the repository at this point in the history