-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watchman required with 2.0.0 when not watching files. #2617
Comments
you can disable watchman, check
|
Thanks for the workaround The option should be opt in instead of opt-out. I would have to now add two versions of this command, which more than a minor annoyance. Consider changing the default for the option. |
I don't think it should just be disabled by default, but it should only be enabled when |
The Quick Start Guide indicates that watchman is an optional dependency, so throwing an error when just following the tutorial-provided command seems... weird, indeed. |
Yeah, we should at least update the docs, thanks for pointing that out! |
I think I have a fix for that: #2643 |
Summary: Here is an updated version of the `GraphQLWatchmanClient.isAvailable`. (as a fix for #2617) Now, it's also checking if the `watchman` CLI is available. Test plan (Tested with `relay-examples:relay-publish-test` (relayjs/relay-examples#89) First of all, I've removed watchman from my machine. Then, - Build the compiler - Install updated dependencies relay-examples (yarn) - Run the compiler (yarn build) Compiled without errors. Pull Request resolved: #2643 Reviewed By: kassens Differential Revision: D14240611 Pulled By: alunyov fbshipit-source-id: 551a9338158debe7db8748676a6dccf0dfd479b0
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hello from 2023, I needed to remove I might need to re-run Edit: Installed Watchman. Wanted the watch feature. |
When running a non watch command like
relay-compiler --schema ./webpack/assets/javascripts/relay/schema.json --extensions js jsx --src ./webpack
in relay 2.0.0, the lack ofwatchman
on the system fails the build.This was not the case with relay 1.7.x. Our CI builds now need watchman. Watchman does not come with prebuilt packages and its not something I want to add to our build.
Is there a chance that this is a regression with 2.0.0
The text was updated successfully, but these errors were encountered: