Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync dependencies with master #89

Closed
wants to merge 8 commits into from
Closed

Sync dependencies with master #89

wants to merge 8 commits into from

Conversation

alunyov
Copy link
Contributor

@alunyov alunyov commented Feb 10, 2019

  • Sync package.json with master
  • Remove graphql-compiler

@alunyov alunyov mentioned this pull request Feb 10, 2019
Closed
facebook-github-bot pushed a commit to facebook/relay that referenced this pull request Feb 28, 2019
@alunyov @facebook-github-bot
What if Watchman CLI is missing... (#2643)
2958b97 
Summary:
Here is an updated version of the `GraphQLWatchmanClient.isAvailable`. (as a fix for #2617)

Now, it's also checking if the `watchman` CLI is available.

Test plan (Tested with `relay-examples:relay-publish-test`  (relayjs/relay-examples#89)

First of all, I've removed watchman from my machine.
Then,
  - Build the compiler
  - Install updated dependencies relay-examples (yarn)
  - Run the compiler (yarn build)

Compiled without errors.
Pull Request resolved: #2643

Reviewed By: kassens

Differential Revision: D14240611

Pulled By: alunyov

fbshipit-source-id: 551a9338158debe7db8748676a6dccf0dfd479b0
@kassens
Copy link
Contributor

kassens commented Mar 14, 2019

This doesn't allow running the examples if you don't have relay checked out and built in the same directory. Probably not a great way for our public examples.

@kassens kassens closed this Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alunyov @kassens @facebook-github-bot