Remove .js and .ts from require / import
#4002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
captbaritone
reviewed
Jul 6, 2022
|
|
||
| if extension == ".js" || extension == ".ts" { | ||
| path = path[0..path.len() - 3].to_string(); | ||
| } |
There was a problem hiding this comment.
the Path/PathBuf types have utilities for extracting the extension, let's use those? there is also the camino crate, which is basically utf8-only versions of Path/PathBuf which might help since the string is already utf8.
-- @josephsavona (internal review)
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
…erated code (#4057) Summary: # What does this PR do * This PR, imported from github, scrubs `.ts` extensions from filepaths in imports in generated typescript files * Typescript does not like `.ts`: microsoft/TypeScript#37582 In the typegen for Typescript when we're writing the pathname for module and type imports, this PR strips any trailing `.ts` that might exist on the path. This is required for TypeScript file imports which don't like the trailing file suffix. This was partially fixed in #4002 but not completely. Pull Request resolved: #4057 Test Plan: 👀 Reviewed By: alunyov Differential Revision: D39437828 Pulled By: rbalicki2 fbshipit-source-id: 53b3f5f7e467cefbc9ae73bf455ca040ea8a69aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3989 (comment)
This PR updates
relay-codegen's printer not to include the file's extension when writing imports / requires. This might be a naive implementation, maybe there's a better, more holistic approach.