Strip extensions on file import paths when writing out TypeScript generated code #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Thank you for making this change. I'll go ahead and import and merge it. |
|
@rbalicki2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4056
In the typegen for Typescript when we're writing the pathname for module and type imports, this PR strips any trailing
.tsthat might exist on the path. This is required for TypeScript file imports which don't like the trailing file suffix. This was partially fixed in #4002 but not completely.I'm new to this repo and it's been a while since I've written some Rust, so definitely let me know if I'm doing anything wrong here or if there's any code I've missed, thanks!
I've also filled out the CLA as well.