-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: Add ImmutableCFOption disable_preload_pinning option #8463
Open
matthewvon
wants to merge
41
commits into
facebook:main
Choose a base branch
from
matthewvon:mv-disable-preload-pinning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
cdf081e
add ImmutableCFOption disable_preload_pinning
matthewvon f530d05
remove testing assert() that needs to NOT be there
matthewvon 8d57520
build_tools/format-diff.sh: required whitespace changes
matthewvon 3c09932
correct capitalization of disablePreloadPinning() function name
matthewvon 460b303
declare enum FilePreload and option file_preload
matthewvon 4096a40
add kFilePreload option type
matthewvon 2302ee8
if options file creation fails, get rid of its temporary file.
matthewvon 47b05cc
utilize new kFilePreload options to determine if files should open no…
matthewvon 7b3378f
add file_preload option the the serialization/deserialization logic a…
matthewvon 1d9c4c2
add file_preload options to ldb cmd and tool.
matthewvon fd9a618
add file_preload to test randomization
matthewvon 85cf693
remove preload options from java interface per Slack discussion
matthewvon 28f3095
update comments and appropriate use of debug_override
matthewvon 2539e4e
white space changes to make Check buck targets happy
matthewvon 2c86b0a
white space changes to make Check buck targets happy
matthewvon 306ce12
white space changes to make Check buck targets happy
matthewvon 911ecec
add FilePreload options
matthewvon 80c0994
remove unnecessary debug_override flag. handle edge case of one file…
matthewvon a734cd7
add test for new file_preload flag
matthewvon 3275af4
Merge branch 'main' into mv-disable-preload-pinning
matthewvon 9705036
fix unrelated bug in options parser so that options_util_test will ex…
matthewvon 99aea0c
clean up shadowing error from CI
matthewvon ab23d65
narrow when zero length vector prints
matthewvon 138d77e
make check buck targets happy
matthewvon be3a403
check the unchecked status variable
matthewvon 3a7d20f
clean up what code runs if file preload is disabled ... fixes Status …
matthewvon dfc5da7
make check buck targets happy
matthewvon 5f06aa3
add test showing corruption will pass
matthewvon e5bc590
Make PreloadCorruption test valid with changing paranoid_checks flag
matthewvon 4c2acb5
disable PreloadCorruption test within ROCKSDB_LITE builds
matthewvon 285bd39
removed explicit rocksdb:: namespace reference ... for CircleCI happi…
matthewvon 01fbbf7
address PR comments
matthewvon aa8785b
convert kFilePreload to more generic kEnum
matthewvon 4e4a700
make check bucks target rule happy ... white space changes
matthewvon 15ab78e
per PR comments, rearrange code so that return Status usage more visi…
matthewvon 943c251
fix white space and move variable definitions for proper compile
matthewvon 3dd190d
Merge branch 'main' into mv-disable-preload-pinning
matthewvon e9e61cb
bad merge
matthewvon 6b183d2
fix a spelling error
matthewvon 53674ed
per PR comments, move file_preload_string_map into cf_options.cc
matthewvon a02e47e
formatting update for CI happiness
matthewvon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
address PR comments
- Loading branch information
commit 01fbbf734f67fab1ba8c2f4d6e4947bc1c424199
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little worried about "Status ret" being moved so far from its setting/use. It seems likely that something will change where we return early and get an unchecked Status. Can the code be restructured (maybe move the files_meta/status outside the if ()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have shifted the code such that the lambda function is away from the threaded preload processing / loops. Added a couple of minor comments. My understanding of the unchecked status stuff is that the naked "Status ret;" will not be seen as unchecked since it is a return value. The caller will need to perform the check.