Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Add ImmutableCFOption disable_preload_pinning option #8463

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

BugFix: Add ImmutableCFOption disable_preload_pinning option #8463

Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
cdf081e
add ImmutableCFOption disable_preload_pinning
matthewvon Jun 25, 2021
f530d05
remove testing assert() that needs to NOT be there
matthewvon Jun 25, 2021
8d57520
build_tools/format-diff.sh: required whitespace changes
matthewvon Jun 25, 2021
3c09932
correct capitalization of disablePreloadPinning() function name
matthewvon Jun 25, 2021
460b303
declare enum FilePreload and option file_preload
matthewvon Jan 4, 2022
4096a40
add kFilePreload option type
matthewvon Jan 4, 2022
2302ee8
if options file creation fails, get rid of its temporary file.
matthewvon Jan 5, 2022
47b05cc
utilize new kFilePreload options to determine if files should open no…
matthewvon Jan 5, 2022
7b3378f
add file_preload option the the serialization/deserialization logic a…
matthewvon Jan 5, 2022
1d9c4c2
add file_preload options to ldb cmd and tool.
matthewvon Jan 5, 2022
fd9a618
add file_preload to test randomization
matthewvon Jan 5, 2022
85cf693
remove preload options from java interface per Slack discussion
matthewvon Jan 5, 2022
28f3095
update comments and appropriate use of debug_override
matthewvon Jan 5, 2022
2539e4e
white space changes to make Check buck targets happy
matthewvon Jan 5, 2022
2c86b0a
white space changes to make Check buck targets happy
matthewvon Jan 5, 2022
306ce12
white space changes to make Check buck targets happy
matthewvon Jan 5, 2022
911ecec
add FilePreload options
matthewvon Jan 6, 2022
80c0994
remove unnecessary debug_override flag. handle edge case of one file…
matthewvon Jan 6, 2022
a734cd7
add test for new file_preload flag
matthewvon Jan 6, 2022
3275af4
Merge branch 'main' into mv-disable-preload-pinning
matthewvon Jan 6, 2022
9705036
fix unrelated bug in options parser so that options_util_test will ex…
matthewvon Jan 7, 2022
99aea0c
clean up shadowing error from CI
matthewvon Jan 7, 2022
ab23d65
narrow when zero length vector prints
matthewvon Jan 7, 2022
138d77e
make check buck targets happy
matthewvon Jan 7, 2022
be3a403
check the unchecked status variable
matthewvon Jan 7, 2022
3a7d20f
clean up what code runs if file preload is disabled ... fixes Status …
matthewvon Jan 7, 2022
dfc5da7
make check buck targets happy
matthewvon Jan 7, 2022
5f06aa3
add test showing corruption will pass
matthewvon Jan 8, 2022
e5bc590
Make PreloadCorruption test valid with changing paranoid_checks flag
matthewvon Jan 8, 2022
4c2acb5
disable PreloadCorruption test within ROCKSDB_LITE builds
matthewvon Jan 8, 2022
285bd39
removed explicit rocksdb:: namespace reference ... for CircleCI happi…
matthewvon Jan 8, 2022
01fbbf7
address PR comments
matthewvon Jan 11, 2022
aa8785b
convert kFilePreload to more generic kEnum
matthewvon Jan 11, 2022
4e4a700
make check bucks target rule happy ... white space changes
matthewvon Jan 11, 2022
15ab78e
per PR comments, rearrange code so that return Status usage more visi…
matthewvon Jan 12, 2022
943c251
fix white space and move variable definitions for proper compile
matthewvon Jan 12, 2022
3dd190d
Merge branch 'main' into mv-disable-preload-pinning
matthewvon Feb 11, 2022
e9e61cb
bad merge
matthewvon Feb 11, 2022
6b183d2
fix a spelling error
matthewvon Feb 11, 2022
53674ed
per PR comments, move file_preload_string_map into cf_options.cc
matthewvon Feb 11, 2022
a02e47e
formatting update for CI happiness
matthewvon Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
white space changes to make Check buck targets happy
  • Loading branch information
@matthewvon
matthewvon committed Jan 5, 2022
commit 306ce12934f74326c2290f7c80079aa9384e13ec
3 changes: 2 additions & 1 deletion port/win/env_win.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

#if defined(OS_WIN)

#include "port/win/env_win.h"

#include <direct.h> // _rmdir, _mkdir, _getcwd
#include <errno.h>
#include <io.h> // _access
Expand All @@ -27,7 +29,6 @@
#include "monitoring/thread_status_util.h"
#include "port/port.h"
#include "port/port_dirent.h"
#include "port/win/env_win.h"
#include "port/win/io_win.h"
#include "port/win/win_logger.h"
#include "port/win/win_thread.h"
Expand Down