Fix the bug that RowIndex column type cannot be serialized #11208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64088125 |
✅ Deploy Preview for meta-velox canceled.
|
hongtaoy
pushed a commit
to hongtaoy/velox
that referenced
this pull request
Oct 9, 2024
…ncubator#11208) Summary: I came across a bug when I tried to serialize a TableScanNode with special row index column. ### The isssue `folly::dynamic HiveColumnHandle::serialize()` uses `columnTypeNames` to serialize the TableScanNode. However, RowIndex is missing in `columnTypeNames`. serialize method would raise a std::out_of_range error because of this. ### The fix The fix is simple -- just add row index column to the map. Differential Revision: D64088125
hongtaoy
force-pushed
the
export-D64088125
branch
from
2191513
to
ffd4ef5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64088125 |
Yuhta
approved these changes
Oct 9, 2024
…ncubator#11208) Summary: I came across a bug when I tried to serialize a TableScanNode with special row index column. ### The isssue `folly::dynamic HiveColumnHandle::serialize()` uses `columnTypeNames` to serialize the TableScanNode. However, RowIndex is missing in `columnTypeNames`. serialize method would raise a std::out_of_range error because of this. ### The fix The fix is simple -- just add row index column to the map. Reviewed By: Yuhta Differential Revision: D64088125
hongtaoy
force-pushed
the
export-D64088125
branch
from
ffd4ef5
to
bc9fafb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64088125 |
|
This pull request has been merged in d5df0a7. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I came across a bug when I tried to serialize a TableScanNode with special row index column.
The isssue
folly::dynamic HiveColumnHandle::serialize()usescolumnTypeNamesto serialize the TableScanNode. However, RowIndex is missing incolumnTypeNames. serialize method would raise a std::out_of_range error because of this.The fix
The fix is simple -- just add row index column to the map.
Differential Revision: D64088125