Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug that RowIndex column type cannot be serialized #11208

Closed
wants to merge 1 commit into from
Closed

Fix the bug that RowIndex column type cannot be serialized #11208

wants to merge 1 commit into from

Commits on Oct 9, 2024

  1. Fix the bug that RowIndex column type cannot be serialized (facebooki… 

    …ncubator#11208)

Summary:

I came across a bug when I tried to serialize a TableScanNode with special row index column. 

### The isssue
`folly::dynamic HiveColumnHandle::serialize()` uses `columnTypeNames` to serialize the TableScanNode. However, RowIndex is missing in `columnTypeNames`. serialize method would raise a std::out_of_range error because of this.

### The fix
The fix is simple -- just add row index column to the map.

Reviewed By: Yuhta

Differential Revision: D64088125
    @facebook-github-bot
    Tao Yang authored and facebook-github-bot committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    bc9fafb View commit details
    Browse the repository at this point in the history