Increase resource usage for scheduled jobs #7811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
assignUser
approved these changes
Dec 1, 2023
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
Summary: This PR tackles several issues with the scheduled fuzzer workflow: - workaround compilation being OOMkilled by using only 8 threads and using `mold` as a linker - this is a stopgap measure only, we should really look at our build times/footprint and see how we can optimize that as a 45 minute build on an 8 core machine is pretty massive. - only compile once (saves ~ 1.5h of CI time) - use actions/cache to save the ccache to further improve build times - add `workflow_dispatch` trigger to enable ad hoc runs of the fuzzer jobs - add `pull_request` trigger to enable testing of the workflow in PRs (like this one ^^) - we could easily move the remaining CCI fuzzer job over to this workflow as well Reverts #7811 to use 8-core machines again. Supersedes #7810 Pull Request resolved: #7842 Reviewed By: mbasmanova Differential Revision: D51960006 Pulled By: kgpai fbshipit-source-id: 0f493f80d5a87cca20bd53f1074a5f4622ee02b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduled fuzzer jobs are currently ooming, https://github.com/facebookincubator/velox/actions/runs/7041471735/job/19164078488 .
Run them on larger instances.