Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve scheduled fuzzer workflow #7842

Closed
wants to merge 15 commits into from
Closed

Improve scheduled fuzzer workflow #7842

wants to merge 15 commits into from

Conversation

assignUser
Copy link
Collaborator

@assignUser assignUser commented Dec 2, 2023 •
edited
Loading

This PR tackles several issues with the scheduled fuzzer workflow:

  • workaround compilation being OOMkilled by using only 8 threads and using mold as a linker
    • this is a stopgap measure only, we should really look at our build times/footprint and see how we can optimize that as a 45 minute build on an 8 core machine is pretty massive.
  • only compile once (saves ~ 1.5h of CI time)
  • use actions/cache to save the ccache to further improve build times
  • add workflow_dispatch trigger to enable ad hoc runs of the fuzzer jobs
  • add pull_request trigger to enable testing of the workflow in PRs (like this one ^^)
    • we could easily move the remaining CCI fuzzer job over to this workflow as well

Reverts #7811 to use 8-core machines again. Supersedes #7810

@netlify Netlify
Copy link

netlify bot commented Dec 2, 2023 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 595bd01
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/65725f7308946200088da2ec

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2023
@assignUser assignUser marked this pull request as draft December 3, 2023 01:59
@assignUser assignUser changed the title [WIP] Use mold to speed up linking and reduce memory footprint. [WIP] Improve scheduled fuzzer workflow Dec 3, 2023
@assignUser assignUser changed the title [WIP] Improve scheduled fuzzer workflow Improve scheduled fuzzer workflow Dec 4, 2023
@assignUser assignUser marked this pull request as ready for review December 4, 2023 17:55
@assignUser assignUser requested a review from kgpai December 4, 2023 17:55
kgpai
kgpai reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@kgpai kgpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

.github/workflows/scheduled.yml Outdated Show resolved Hide resolved
.github/workflows/scheduled.yml Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@assignUser assignUser mentioned this pull request Dec 8, 2023
Closed
@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in af0d9ae.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit af0d9ae9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@assignUser assignUser mentioned this pull request Dec 9, 2023
Closed
facebook-github-bot pushed a commit that referenced this pull request Dec 12, 2023
@assignUser @facebook-github-bot
Enable custom inputs on fuzzer job (#7946)
5342711 
Summary:
A minor fix following #7842 to enable the inputs in the actions web ui.

Pull Request resolved: #7946

Reviewed By: kagamiori

Differential Revision: D52001596

Pulled By: kgpai

fbshipit-source-id: 7d9c026a2852d495f129e3c9c7345d03bf51ac8b
@assignUser assignUser mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgpai kgpai kgpai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@assignUser @facebook-github-bot @kgpai