Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pack: support network name overrides in bundle git tags #10294

Merged
merged 7 commits into from
Feb 17, 2023

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Feb 16, 2023

Related Issues

#10185 (comment)

Proposed Changes

add support for overrides

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snissn snissn requested a review from a team as a code owner February 16, 2023 17:35
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's still one piece of information that needs to be passed through, which is the actors version being updated. As currently written, we'll respect the network overrides, but still set all actor versions to the git tag, not just the one being packed.

As an example, ./pack.sh v9 dev/20230114-pre-rc.2 mainnet=v9.0.3 calibrationnet=v9.0.0 devnet=v9.0.3 devnet-wasm=v9.0.3 testing=v9.0.3 testing-fake-proofs=v9.0.3 butterflynet=v9.0.2 should only update v9 actors.

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only issue I see with this is that it's gonna skip the metadata for those versions we aren't setting, leading to them getting overwritten.

I think we can just drop the metadataSpecificVersion, and mutate the metadata object in place. That will modify it as needed, while leaving everything else untouched.

gen/bundle/bundle.go Outdated Show resolved Hide resolved
gen/bundle/bundle.go Outdated Show resolved Hide resolved
@arajasek arajasek merged commit 7a35a73 into release/v1.20.0 Feb 17, 2023
@arajasek arajasek deleted the mikers/buildReleaseOverrides branch February 17, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants