Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pack: support network name overrides in bundle git tags #10294

Merged
merged 7 commits into from
Feb 17, 2023
Merged

fix: pack: support network name overrides in bundle git tags #10294

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e678f2
support network name overrides in pack to build releases
snissn Feb 16, 2023
16b7d45
lintfix
snissn Feb 16, 2023
ea03e1b
only override the correct version for bundle gen
snissn Feb 16, 2023
0f6cbf1
include the version that pack is running on for filtering the build g…
snissn Feb 16, 2023
dbcf304
clean up comment remove print
snissn Feb 17, 2023
4dedced
lintfix
snissn Feb 17, 2023
f41435d
feat: bundle: only write git tags for newly packed bundles
arajasek Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
only override the correct version for bundle gen
  • Loading branch information
@snissn
snissn committed Feb 16, 2023
commit ea03e1b6e70969e3c4bc7194bdf12b4b2aac7a45
3 changes: 2 additions & 1 deletion gen/bundle/bundle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package main

import (
"fmt"
"os"
"strings"
"text/template"
Expand Down Expand Up @@ -56,7 +57,7 @@ func main() {
if len(os.Args) > 1 {
for _, m := range metadata {
override, ok := overrides[m.Network]
if ok {
if ok && strings.HasPrefix(override, fmt.Sprintf("v%d", m.Version)) {
m.BundleGitTag = override
} else {
m.BundleGitTag = os.Args[1]
Expand Down