Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Fireperf SDK to support tree-shaking by removing side-effects #3801

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jposuna
Copy link
Contributor

@jposuna jposuna commented Sep 16, 2020

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2020

💥 No Changeset

Latest commit: e133ef2

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jposuna jposuna force-pushed the jposuna-dev branch 3 times, most recently from c5ab2ba to 49eb32e Compare September 16, 2020 22:29
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 16, 2020

Binary Size Report

Affected SDKs

  • @firebase/performance-exp

    Type Base (7086f4a) Head (dde54af) Diff
    browser 27.4 kB 28.5 kB +1.05 kB (+3.8%)
    esm2017 25.4 kB 26.7 kB +1.29 kB (+5.1%)
    main 27.4 kB 28.5 kB +1.05 kB (+3.8%)
    module 27.1 kB 28.4 kB +1.22 kB (+4.5%)

Test Logs

@jposuna jposuna force-pushed the jposuna-dev branch 7 times, most recently from 3bba7f3 to f2e9d34 Compare September 17, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants