Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the Fireperf SDK to support tree-shaking by removing side-effects #3801

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Updating the Fireperf SDK to support tree-shaking by removing side-effects #3801

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1e9d84
Updating the dependencies for performance-exp to use the exp packages…
jposuna Sep 16, 2020
d094b8c
Moving index.ts under scr/
jposuna Sep 16, 2020
e133ef2
Updating the Fireperf SDK to support tree-shaking by removing side-ef…
jposuna Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Moving index.ts under scr/
  • Loading branch information
@jposuna
jposuna committed Sep 16, 2020
commit d094b8c983db9889326efbfc19c52df915b1ae99
4 changes: 2 additions & 2 deletions packages-exp/performance-exp/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const es5BuildPlugins = [typescriptPlugin({ typescript }), json()];

const es5Builds = [
{
input: 'index.ts',
input: 'src/index.ts',
output: [
{ file: pkg.main, format: 'cjs', sourcemap: true },
{ file: pkg.module, format: 'es', sourcemap: true }
Expand Down Expand Up @@ -59,7 +59,7 @@ const es2017BuildPlugins = [

const es2017Builds = [
{
input: 'index.ts',
input: 'src/index.ts',
output: [{ file: pkg.esm2017, format: 'es', sourcemap: true }],
plugins: es2017BuildPlugins,
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
Expand Down
10 changes: 5 additions & 5 deletions packages-exp/performance-exp/index.ts → packages-exp/performance-exp/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@

import { FirebaseApp } from '@firebase/app-types-exp';
import { FirebasePerformance } from '@firebase/performance-types-exp';
import { ERROR_FACTORY, ErrorCode } from './src/utils/errors';
import { setupApi } from './src/services/api_service';
import { PerformanceController } from './src/controllers/perf';
import { ERROR_FACTORY, ErrorCode } from './utils/errors';
import { setupApi } from './services/api_service';
import { PerformanceController } from './controllers/perf';
import {
_registerComponent,
_getProvider,
Expand All @@ -31,8 +31,8 @@ import {
Component,
ComponentType
} from '@firebase/component';
import { SettingsService } from './src/services/settings_service';
import { name, version } from './package.json';
import { SettingsService } from './services/settings_service';
import { name, version } from '../package.json';

const DEFAULT_ENTRY_NAME = '[DEFAULT]';

Expand Down