This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
[Editor] do not update highlight line by default #6590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomsy
reviewed
Jul 4, 2018
| return true; | ||
| if ( | ||
| editorLine !== this.previousEditorLine || | ||
| this.props.selectedSource !== selectedSource |
There was a problem hiding this comment.
with this.props.selectedSource !== selectedSource,it seems to make the highlight flash really quick, that sometimes you might not see the line highlighted.
|
We might not need this once #6601 lands |
|
is this still needed? |
|
I don't think so!
…On Fri, Jul 6, 2018, 5:39 PM Hubert Boma Manilla ***@***.***> wrote:
is this still needed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6590 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPiYvXVOmeCIfF7au_cJ1mx1LYcwBWSks5uD9kUgaJpZM4VBAKH>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #6588
Summary of Changes
Previously we were updating the highlight line if two conditions were not met. Now, we update it if those conditions are not met and a some others are. This will prevent spurious re-renders.