Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[Editor] do not update highlight line by default #6590

Closed
wants to merge 2 commits into from
Closed

[Editor] do not update highlight line by default #6590

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c255d1
[Editor] do not update highlight line by default
jasonLaster Jul 3, 2018
5814d36
highlight line
jasonLaster Jul 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/Editor/HighlightLine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,14 @@ export class HighlightLine extends Component<Props> {
return false;
}

return true;
if (
editorLine !== this.previousEditorLine ||
this.props.selectedSource !== selectedSource
Copy link
Contributor

@bomsy bomsy Jul 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this.props.selectedSource !== selectedSource,it seems to make the highlight flash really quick, that sometimes you might not see the line highlighted.

) {
return true;
}

return false;
}

componentDidUpdate(prevProps: Props) {
Expand Down