Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CSS Code Housekeeping" #3085

Closed
wants to merge 1 commit into from

Conversation

askvortsov1
Copy link
Sponsor Member

Reverts #3026

This PR broke some components on Safari:

image

image
image

@askvortsov1 askvortsov1 added this to the 1.1 milestone Sep 28, 2021
@SychO9
Copy link
Member

SychO9 commented Sep 28, 2021

do we know if it's a specific change ? I can't think of any change in that PR that could affect those icons, most of those changes was just minor cleanup, none of which really directly affect any of the dropdown elements.

@askvortsov1
Copy link
Sponsor Member Author

do we know if it's a specific change ? I can't think of any change in that PR that could affect those icons, most of those changes was just minor cleanup, none of which really directly affect any of the dropdown elements.

I'm not 100% sure, all I know is that with browserstack, it worked before this commit but didn't work afterwards. Maybe some of the vendor prefixes were actually needed? If you have time, we can try and salvage out the working parts, but if not, might be better to revert entirely and revisit next cycle.

@SychO9 SychO9 deleted the revert-3026-sm/css-code-cleanup branch September 29, 2021 15:33
@SychO9 SychO9 removed this from the 1.1 milestone Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants