Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CSS Code Housekeeping" #3085

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions less/admin/AdminNav.less
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,20 @@
}

@media @phone, @tablet {
.AdminNav {
.App-nav .AdminNav {
.Dropdown-menu {
> li {
.ExtensionListTitle {
color: @muted-color;
text-transform: uppercase;
margin: 25px 0 10px 15px;
}

.ExtensionIcon {
margin: -2px -29px;
--size: 25px;
width: 25px;
height: 25px;
font-size: 12.5px;

.icon {
margin: 0;
Expand All @@ -75,7 +83,7 @@
top: @header-height;
height: ~"calc(100vh - @{header-height})";
width: @admin-pane-width;
box-shadow: 0 6px 6px @shadow-color;
.box-shadow(0 6px 6px @shadow-color);
background: @body-bg;
z-index: @zindex-pane;
overflow-y: scroll;
Expand Down Expand Up @@ -149,9 +157,18 @@
margin: 0 auto;
}

.ExtensionListTitle {
color: @muted-color;
text-transform: uppercase;
margin: 25px 0 8px 15px;
}

.ExtensionIcon {
--size: 25px;
width: 25px;
height: 25px;
font-size: 15px;
margin-left: -29px;
vertical-align: middle;
}
}
}
Expand All @@ -176,12 +193,6 @@
padding-left: 5px;
}

.ExtensionListTitle {
color: @muted-color;
text-transform: uppercase;
margin: 25px 0 8px 15px;
}

.ExtensionListItem-Dot {
height: 10px;
width: 10px;
Expand Down
21 changes: 13 additions & 8 deletions less/admin/ExtensionPage.less
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
.ExtensionPage {

&-header {
.ExtensionTitle {
display: flex;
align-items: center;
flex-wrap: wrap;
margin: 20px 0 15px;
}

.helpText {
margin-bottom: 5px;
}
Expand Down Expand Up @@ -71,8 +79,11 @@
}

.ExtensionIcon {
--size: 30px;
width: 30px;
height: 30px;
font-size: 15px;
margin-left: 0;
vertical-align: middle;
}

&TopItems {
Expand Down Expand Up @@ -112,6 +123,7 @@
}

&-permissions {

.PermissionGrid-removeScope {
display: none;
}
Expand All @@ -128,13 +140,6 @@
}
}

.ExtensionTitle {
display: flex;
align-items: center;
flex-wrap: wrap;
margin: 20px 0 15px;
}

.ExtensionInfo {
margin-left: auto;

Expand Down
7 changes: 3 additions & 4 deletions less/admin/ExtensionWidget.less
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,13 @@
}

.ExtensionIcon {
--size: 90px;
width: var(--size);
height: var(--size);
width: 90px;
height: 90px;
background: @control-bg;
color: @control-color;
border-radius: 6px;
display: inline-flex;
font-size: calc(~"var(--size) / 2");
font-size: 45px;
text-align: center;
align-items: center;
justify-content: center;
Expand Down
4 changes: 2 additions & 2 deletions less/admin/PermissionsPage.less
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
display: none;
}
.open .Dropdown-toggle {
box-shadow: none;
.box-shadow(none);
}
}
}
Expand All @@ -128,7 +128,7 @@
}
.Badge {
margin: -3px 3px -3px 0;
box-shadow: none;
.box-shadow(none);
}
}
.PermissionGrid-section {
Expand Down
29 changes: 13 additions & 16 deletions less/common/Alert.less
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,6 @@
border-radius: @border-radius;
line-height: 1.5;

background: var(--alert-bg);

&,
a,
a:hover,
.Button,
.Button:hover,
.Button:active,
.Button.active,
.Button:focus,
.Button.focus {
color: var(--alert-color);
}

.Alert--color(@alert-color, @alert-bg);
}
.Alert--error {
Expand All @@ -30,8 +16,19 @@
}
}
.Alert--color(@color; @background) {
--alert-bg: @background;
--alert-color: @color;
background: @background;

&,
a,
a:hover,
.Button,
.Button:hover,
.Button:active,
.Button.active,
.Button:focus,
.Button.focus {
color: @color;
}
}
.Alert-controls {
list-style-type: none;
Expand Down
2 changes: 1 addition & 1 deletion less/common/AlertManager.less
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
.Alert {
display: inline-block;
margin-top: 20px;
box-shadow: 0 2px 6px @shadow-color;
.box-shadow(0 2px 6px @shadow-color);
}
}
14 changes: 7 additions & 7 deletions less/common/App.less
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
}

.scrolled & {
box-shadow: 0 2px 6px @shadow-color;
.box-shadow(0 2px 6px @shadow-color);
}
}
.App-primaryControl, .App-titleControl, .App-backControl {
Expand All @@ -40,7 +40,7 @@
> .Button {
float: none;
background: transparent !important;
box-shadow: none !important;
.box-shadow(~"none !important");
height: @header-height-phone;
width: auto;
padding: 13px !important;
Expand Down Expand Up @@ -136,9 +136,9 @@
left: 0;
top: 0;
bottom: 0;
box-shadow: 0 2px 6px @shadow-color;
transform: translate(-@drawer-width - 6px, 0);
transition: transform 0.2s;
.box-shadow(0 2px 6px @shadow-color);
.translate3d(-@drawer-width - 6px, 0, 0);
.transition-transform(0.2s);
z-index: @zindex-modal;

.drawerOpen & {
Expand All @@ -155,7 +155,7 @@
z-index: @zindex-modal-background;
background-color: @overlay-bg;
opacity: 0;
transition: opacity 0.2s;
.transition(0.2s opacity);

&.in {
opacity: 0.9;
Expand Down Expand Up @@ -241,7 +241,7 @@
}

.scrolled & {
box-shadow: 0 2px 6px @shadow-color;
.box-shadow(0 2px 6px @shadow-color);
}

& when (@config-colored-header = true) {
Expand Down
15 changes: 7 additions & 8 deletions less/common/Avatar.less
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
.Avatar {
display: inline-flex;
align-items: center;
justify-content: center;
display: inline-block;
box-sizing: content-box;
color: #fff;
text-align: center;
vertical-align: top;
background-color: var(--avatar-bg);
font-weight: normal;
.Avatar--size(48px);
width: var(--size);
height: var(--size);
border-radius: 100%;
font-size: calc(~"var(--size) / 2");

img {
display: inline-block;
Expand All @@ -23,5 +18,9 @@
}

.Avatar--size(@size) {
--size: @size;
width: @size;
height: @size;
border-radius: @size;
font-size: @size / 2;
line-height: @size;
}
23 changes: 11 additions & 12 deletions less/common/Badge.less
Original file line number Diff line number Diff line change
@@ -1,27 +1,26 @@
.Badge {
.Badge--size(22px);
width: var(--size);
height: var(--size);
border-radius: calc(~"var(--size) / 2");
background: var(--badge-bg);
color: var(--badge-color);
display: inline-flex;
align-items: center;
justify-content: center;
display: inline-block;
vertical-align: middle;
box-shadow: 0 2px 4px @shadow-color;
text-align: center;
.box-shadow(0 2px 4px @shadow-color);

.Badge-label {
display: none;
}

&, .Badge-icon {
font-size: calc(~"0.56 * var(--size)");
}
}

.Badge--size(@size) {
--size: @size;
width: @size;
height: @size;
border-radius: @size / 2;
line-height: @size - 1px;

&, .Badge-icon {
font-size: 0.56 * @size;
}
}

.badges {
Expand Down
8 changes: 4 additions & 4 deletions less/common/Button.less
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
fieldset[disabled] & {
cursor: default;
opacity: 0.65;
box-shadow: none;
.box-shadow(none);
}

a& {
Expand All @@ -82,7 +82,7 @@
}

.Button-label {
transition: margin-right 0.1s;
.transition(margin-right 0.1s);
}

.LoadingIndicator-container {
Expand Down Expand Up @@ -142,7 +142,7 @@
&.focus,
.open > &.Dropdown-toggle {
background: transparent !important;
box-shadow: none;
.box-shadow(none);
color: @link-color;
}
}
Expand All @@ -158,7 +158,7 @@
&:active,
&.active,
.open > &.Dropdown-toggle {
box-shadow: none;
.box-shadow(none);
}
}
.Button--primary {
Expand Down
4 changes: 2 additions & 2 deletions less/common/Checkbox.less
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
position: relative;
border-radius: 14px;
background: @control-bg;
transition: background-color 0.2s;
.transition(background-color 0.2s);

.LoadingIndicator {
--size: 22px !important;
Expand Down Expand Up @@ -81,7 +81,7 @@
height: 22px;
padding: 0;
left: 3px;
transition: opacity 0.2s, left 0.2s;
.transition(~"opacity 0.2s, left 0.2s");

.on& {
left: 25px;
Expand Down
Loading