Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispositioning PRs since v 0.5.0 #440

Conversation

SeanCurtis-TRI
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI commented Feb 5, 2020

This is the exhaustive list of all PRs since v 0.5.0, summarized and grouped (as appropriate).

This also includes a re-format so that it fits within an 80-column document.


This change is Reviewable

@SeanCurtis-TRI SeanCurtis-TRI force-pushed the PR_update_change_Log branch 2 times, most recently from 1ddae70 to 25554fc Compare February 5, 2020 21:13
Copy link
Contributor Author

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sherm1 for review

This isn't code at all. Just listing PRs in the change log. I'll let you decide to what granularity you'd like to delve into the details.

Once you approve the content, I propose we can merge this without necessarily waiting on CI. (Although I still might just for the pretty green checkmarks).

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @sherm1)

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: I love it -- the meaningful groupings are a nice touch!

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @sherm1)

This is the exhaustive list of all PRs since v 0.5.0, summarized and
grouped (as appropriate).

This also includes a re-format so that it fits within an 80-column
document.
Copy link
Contributor Author

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of master. We'll let CI run through and then merge.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @sherm1)

Copy link
Contributor Author

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind -- given that it's only a change to a markdown documentation file, we'll go ahead and force merge it. This is the final candidate for release 0.6.0 and we'd like to stress test it and can use the time.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @sherm1)

@SeanCurtis-TRI SeanCurtis-TRI merged commit a13c681 into flexible-collision-library:master Feb 7, 2020
@SeanCurtis-TRI SeanCurtis-TRI deleted the PR_update_change_Log branch February 7, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants