-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor "app plugin loader" Gradle Plugin so it can be applied using the declarative plugins {}
block
#127897
Refactor "app plugin loader" Gradle Plugin so it can be applied using the declarative plugins {}
block
#127897
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
module_plugin_loader should be refactored like this as well. |
c529665
to
4f683b3
Compare
Problem 1: I cannot get Problem 2: |
Dismissing review from @dnfield as stale (all points were addressed), so I can get autosubmit to stick. |
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
… the declarative `plugins {}` block (flutter#127897) This PR fixes flutter#125009.
…lied using the declarative `plugins {}` block (flutter/flutter#127897)
This PR fixes #125009.
Pre-launch Checklist
///
).