Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor "app plugin loader" Gradle Plugin so it can be applied using the declarative plugins {} block #127897

Merged
merged 38 commits into from
Sep 22, 2023
Merged

Refactor "app plugin loader" Gradle Plugin so it can be applied using the declarative plugins {} block #127897

merged 38 commits into from
Sep 22, 2023

Commits on May 30, 2023

  1. create flutter-plugin-loader (FlutterAppPluginLoaderPlugin)

    @bartekpacia
    bartekpacia committed May 30, 2023
    Configuration menu
    Copy the full SHA
    262fd8c View commit details
    Browse the repository at this point in the history

  2. use flutter-plugin-loader in examples/hello_world

    @bartekpacia
    bartekpacia committed May 30, 2023
    Configuration menu
    Copy the full SHA
    0018a4d View commit details
    Browse the repository at this point in the history

  3. fix plugins not being applied

    @bartekpacia
    bartekpacia committed May 30, 2023
    Configuration menu
    Copy the full SHA
    05be653 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. update settings.gradle template to use declarative plugin apply

    @bartekpacia
    bartekpacia committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4f683b3 View commit details
    Browse the repository at this point in the history

  2. move plugins block up

    @bartekpacia
    bartekpacia committed May 31, 2023
    Configuration menu
    Copy the full SHA
    21b89ee View commit details
    Browse the repository at this point in the history

  3. add debug logs

    @bartekpacia
    bartekpacia committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0470e6a View commit details
    Browse the repository at this point in the history

  4. move plugins block up in the template settings.gradle

    @bartekpacia
    bartekpacia committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5e740cb View commit details
    Browse the repository at this point in the history

  5. hack around com.android.build.tools not being resoled at runtime in… 

    … FGP
    @bartekpacia
    bartekpacia committed May 31, 2023
    Configuration menu
    Copy the full SHA
    d64b094 View commit details
    Browse the repository at this point in the history

  6. Revert "hack around com.android.build.tools not being resoled at ru… 

    …ntime in FGP"

This reverts commit d64b094.
    @bartekpacia
    bartekpacia committed May 31, 2023
    Configuration menu
    Copy the full SHA
    67f2ff3 View commit details
    Browse the repository at this point in the history

  7. try to add buildscript dependency on AGP

    @bartekpacia
    bartekpacia committed May 31, 2023
    Configuration menu
    Copy the full SHA
    fc7d67c View commit details
    Browse the repository at this point in the history

  8. add debug prints

    @bartekpacia
    bartekpacia committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4fedadb View commit details
    Browse the repository at this point in the history

  9. Revert "Revert "hack around com.android.build.tools not being resol… 

    …ed at runtime in FGP""

This reverts commit 67f2ff3.
    @bartekpacia
    bartekpacia committed May 31, 2023
    Configuration menu
    Copy the full SHA
    98b42b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. remove all debug prints

    @bartekpacia
    bartekpacia committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    5df0a52 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. move FlutterPluginKts into its own file 

    fails with:

* Where:
Build file '/Users/bartek/fvm/versions/master/examples/hello_world/android/build.gradle' line: 39

* What went wrong:
A problem occurred evaluating root project 'android'.
> Build completed with 1 failures.
   > 'void Flutter_gradle.<init>(org.gradle.kotlin.dsl.support.KotlinScriptHost, org.gradle.api.Project)'
    @bartekpacia
    bartekpacia committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    9d20179 View commit details
    Browse the repository at this point in the history

  2. Revert "move FlutterPluginKts into its own file" 

    This reverts commit 9d20179.
    @bartekpacia
    bartekpacia committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    d4924c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. clean up a bit, introduce settings.gradle.kts

    @bartekpacia
    bartekpacia committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    ab715de View commit details
    Browse the repository at this point in the history

  2. Revert "hack around com.android.build.tools not being resoled at ru… 

    …ntime in FGP"

This reverts commit d64b094.
    @bartekpacia
    bartekpacia committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    20a6645 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Merge branch 'master' into declarative_app_plugin_loader_gradle_plugin

    @bartekpacia
    bartekpacia committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    976b697 View commit details
    Browse the repository at this point in the history

  2. apply a stranger's pro-uber-tip 

    This fixes `com/android/build/OutputFile` not being and failing the build.
    @bartekpacia
    bartekpacia committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    a0cc9b5 View commit details
    Browse the repository at this point in the history

  3. hello_world app: bump AGP to 7.4.2, bump Gradle to 8.2.1, bump Kotlin… 

    … to 1.9.0
    @bartekpacia
    bartekpacia committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    f850115 View commit details
    Browse the repository at this point in the history

  4. hello_world app: regenerate lockfiles

    @bartekpacia
    bartekpacia committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    b997eba View commit details
    Browse the repository at this point in the history

  5. templates/app_share: update to use declarative apply of Flutter setti… 

    …ngs plugin
    @bartekpacia
    bartekpacia committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    63e2c33 View commit details
    Browse the repository at this point in the history

  6. debug why app_shared/android.tmpl/settings.gradle.tmpl isn't genera… 

    …ted in `flutter create`
    @bartekpacia
    bartekpacia committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    b531f77 View commit details
    Browse the repository at this point in the history

  7. add app_shared/android.tmpl/settings.gradle.tmpl to the template ma… 

    …nifest
    @bartekpacia
    bartekpacia committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    096c0d4 View commit details
    Browse the repository at this point in the history

  8. Revert "debug why app_shared/android.tmpl/settings.gradle.tmpl isn'… 

    …t generated in `flutter create`"

This reverts commit b531f77.
    @bartekpacia
    bartekpacia committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    b60376d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into declarative_app_plugin_loader_gradle_plugin

    @bartekpacia
    bartekpacia committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    b90c418 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Merge branch 'master' into declarative_app_plugin_loader_gradle_plugin

    @bartekpacia
    bartekpacia committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    d13215a View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. settings.gradle.tmpl: update repositories to use follow new order 

    new order: `google`, `mavenCentral`, `gradlePluginPortal`
    @bartekpacia
    bartekpacia committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    29b01c3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into declarative_app_plugin_loader_gradle_plugin

    @bartekpacia
    bartekpacia committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a79f5a4 View commit details
    Browse the repository at this point in the history

  3. update AGP version from 7.3.0 to 7.4.2

    @bartekpacia
    bartekpacia committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    0e7e128 View commit details
    Browse the repository at this point in the history

  4. Revert "update AGP version from 7.3.0 to 7.4.2" (causes problems) 

    This reverts commit 0e7e128.
    @bartekpacia
    bartekpacia committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    b2fc7d5 View commit details
    Browse the repository at this point in the history

  5. (EXPERIMENT) Revert "settings.gradle.tmpl: update repositories to u… 

    …se follow new order"

This reverts commit 29b01c3.
    @bartekpacia
    bartekpacia committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a39fc08 View commit details
    Browse the repository at this point in the history

  6. Revert "(EXPERIMENT) Revert "settings.gradle.tmpl: update `repositori… 

    …es` to use follow new order""

This reverts commit a39fc08.
    @bartekpacia
    bartekpacia committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    4121331 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into declarative_app_plugin_loader_gradle_plugin

    @bartekpacia
    bartekpacia committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d8fecca View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into declarative_app_plugin_loader_gradle_plugin

    @bartekpacia
    bartekpacia committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    e7112eb View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Merge branch 'master' into declarative_app_plugin_loader_gradle_plugin

    @bartekpacia
    bartekpacia committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1ff1a14 View commit details
    Browse the repository at this point in the history

  2. app_plugin_loader: extract native_build into a private final

    @bartekpacia
    bartekpacia committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    06fd686 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Merge branch 'master' into declarative_app_plugin_loader_gradle_plugin

    @bartekpacia
    bartekpacia committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    82efb99 View commit details
    Browse the repository at this point in the history