Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover more test/widgets tests with leak tracking #5 #134869

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

ksokolovskyi
Copy link
Contributor

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Tests

  • Updates listener_test.dart to use testWidgetsWithLeakTracking;
  • Updates listview_end_append_test.dart to use testWidgetsWithLeakTracking;
  • Updates localizations_test.dart to use testWidgetsWithLeakTracking;
  • Updates lookup_boundary_test.dart to use testWidgetsWithLeakTracking;
  • Updates magnifier_test.dart to use testWidgetsWithLeakTracking;
  • Updates mark_needs_build_test.dart to use testWidgetsWithLeakTracking;
  • Updates media_query_test.dart to use testWidgetsWithLeakTracking;
  • Updates modal_barrier_test.dart to use testWidgetsWithLeakTracking;
  • Updates mouse_region_test.dart to use testWidgetsWithLeakTracking;
  • Updates multi_view_binding_test.dart to use testWidgetsWithLeakTracking;
  • Updates multi_view_tree_updates_test.dart to use testWidgetsWithLeakTracking;
  • Updates multichild_test.dart to use testWidgetsWithLeakTracking;
  • Updates multichildobject_with_keys_test.dart to use testWidgetsWithLeakTracking;
  • Updates navigator_and_layers_test.dart to use testWidgetsWithLeakTracking;
  • Updates navigator_replacement_test.dart to use testWidgetsWithLeakTracking;
  • Updates navigator_restoration_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. labels Sep 16, 2023
@ksokolovskyi
Copy link
Contributor Author

cc @polina-c

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 18, 2023

auto label is removed for flutter/flutter/134869, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@ksokolovskyi
Copy link
Contributor Author

@polina-c thanks for the review!

@polina-c polina-c merged commit 56cbf3e into flutter:master Sep 18, 2023
67 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 19, 2023
flutter/flutter@b7d0e8c...8936504

2023-09-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998)
2023-09-19 polinach@google.com Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983)
2023-09-18 zanderso@users.noreply.github.com Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978)
2023-09-18 polinach@google.com Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953)
2023-09-18 47866232+chunhtai@users.noreply.github.com Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954)
2023-09-18 v.ditsyak@gmail.com Access to fragment in router state on page refresh (flutter/flutter#131123)
2023-09-18 goderbauer@google.com Enable private field promotion for framework (flutter/flutter#134473)
2023-09-18 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking #6 (flutter/flutter#134884)
2023-09-18 polinach@google.com Cover more tests with leak tracking. (flutter/flutter#134805)
2023-09-18 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking #5 (flutter/flutter#134869)
2023-09-18 15619084+vashworth@users.noreply.github.com Don't uninstall before retrying to connect during app launch (flutter/flutter#134542)
2023-09-18 xilaizhang@google.com [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955)
2023-09-18 sokolovskyi.konstantin@gmail.com Fix memory leak in _DarwinViewState. (flutter/flutter#134938)
2023-09-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956)
2023-09-18 104349824+huycozy@users.noreply.github.com Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
…r#4947)

flutter/flutter@b7d0e8c...8936504

2023-09-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998)
2023-09-19 polinach@google.com Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983)
2023-09-18 zanderso@users.noreply.github.com Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978)
2023-09-18 polinach@google.com Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953)
2023-09-18 47866232+chunhtai@users.noreply.github.com Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954)
2023-09-18 v.ditsyak@gmail.com Access to fragment in router state on page refresh (flutter/flutter#131123)
2023-09-18 goderbauer@google.com Enable private field promotion for framework (flutter/flutter#134473)
2023-09-18 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking flutter#6 (flutter/flutter#134884)
2023-09-18 polinach@google.com Cover more tests with leak tracking. (flutter/flutter#134805)
2023-09-18 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking flutter#5 (flutter/flutter#134869)
2023-09-18 15619084+vashworth@users.noreply.github.com Don't uninstall before retrying to connect during app launch (flutter/flutter#134542)
2023-09-18 xilaizhang@google.com [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955)
2023-09-18 sokolovskyi.konstantin@gmail.com Fix memory leak in _DarwinViewState. (flutter/flutter#134938)
2023-09-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956)
2023-09-18 104349824+huycozy@users.noreply.github.com Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants