-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland Resolve breaking change of adding a method to ChangeNotifier. #134983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you note what the fix was?
Done |
zanderso
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @goderbauer
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 19, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 19, 2023
flutter/flutter@b7d0e8c...8936504 2023-09-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998) 2023-09-19 polinach@google.com Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983) 2023-09-18 zanderso@users.noreply.github.com Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978) 2023-09-18 polinach@google.com Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953) 2023-09-18 47866232+chunhtai@users.noreply.github.com Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954) 2023-09-18 v.ditsyak@gmail.com Access to fragment in router state on page refresh (flutter/flutter#131123) 2023-09-18 goderbauer@google.com Enable private field promotion for framework (flutter/flutter#134473) 2023-09-18 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking #6 (flutter/flutter#134884) 2023-09-18 polinach@google.com Cover more tests with leak tracking. (flutter/flutter#134805) 2023-09-18 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking #5 (flutter/flutter#134869) 2023-09-18 15619084+vashworth@users.noreply.github.com Don't uninstall before retrying to connect during app launch (flutter/flutter#134542) 2023-09-18 xilaizhang@google.com [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955) 2023-09-18 sokolovskyi.konstantin@gmail.com Fix memory leak in _DarwinViewState. (flutter/flutter#134938) 2023-09-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956) 2023-09-18 104349824+huycozy@users.noreply.github.com Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
…r#4947) flutter/flutter@b7d0e8c...8936504 2023-09-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998) 2023-09-19 polinach@google.com Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983) 2023-09-18 zanderso@users.noreply.github.com Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978) 2023-09-18 polinach@google.com Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953) 2023-09-18 47866232+chunhtai@users.noreply.github.com Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954) 2023-09-18 v.ditsyak@gmail.com Access to fragment in router state on page refresh (flutter/flutter#131123) 2023-09-18 goderbauer@google.com Enable private field promotion for framework (flutter/flutter#134473) 2023-09-18 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking flutter#6 (flutter/flutter#134884) 2023-09-18 polinach@google.com Cover more tests with leak tracking. (flutter/flutter#134805) 2023-09-18 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking flutter#5 (flutter/flutter#134869) 2023-09-18 15619084+vashworth@users.noreply.github.com Don't uninstall before retrying to connect during app launch (flutter/flutter#134542) 2023-09-18 xilaizhang@google.com [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955) 2023-09-18 sokolovskyi.konstantin@gmail.com Fix memory leak in _DarwinViewState. (flutter/flutter#134938) 2023-09-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956) 2023-09-18 104349824+huycozy@users.noreply.github.com Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
f: focus
Focus traversal, gaining or losing focus
f: material design
flutter/packages/flutter/material repository.
f: routes
Navigator, Router, and related APIs.
f: scrolling
Viewports, list views, slivers, etc.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted PR: #134978
Issues fixed: #134978 (comment)
Updated material/app_test.dart to call
ChangeNotifier.maybeDispatchObjectCreation(this);
instead ofmaybeDispatchObjectCreation();
Not sure why tests passed for previous PR.