Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Use the application ID in the application support path #2845

Merged

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Jun 24, 2020

Description

Use the application ID in the application support path. The existing code uses the binary name, which is not necessarily unique. Application IDs were recently added to the Linux shell.

Related Issues

flutter/flutter#59234

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits. We'll need a follow-up once this is landed and published that's a breaking change for path_provider itself to use this version of path_provider_linux.

Normally I would say we need to provide a utility method to allow people to migrate things, but since this is very new and Linux is still a technical preview, I don't think it's going to be necessary. If someone really wants it, it can always be added in a follow-up.

packages/path_provider/path_provider_linux/CHANGELOG.md Outdated Show resolved Hide resolved
packages/path_provider/path_provider_linux/CHANGELOG.md Outdated Show resolved Hide resolved
packages/path_provider/path_provider_linux/CHANGELOG.md Outdated Show resolved Hide resolved
@robert-ancell robert-ancell merged commit 7d4a918 into flutter:master Jul 21, 2020
@robert-ancell robert-ancell deleted the linux-path-provider-app-id branch July 21, 2020 04:58
@ditman
Copy link
Member

ditman commented Jul 24, 2020

This PR seems to have broken tests in master?

Starting application: test_driver/path_provider_e2e.dart
Building Linux application...                                   
flutter: Observatory listening on http://127.0.0.1:40955/2sSfCrcKzAA=/
flutter: 00:00 +0: getTemporaryDirectory
flutter: 00:00 +1: getDownloadDirectory
flutter: 00:00 +2: getApplicationDocumentsDirectory
flutter: 00:00 +3: getApplicationSupportDirectory
Timed out!

dnfield added a commit that referenced this pull request Jul 24, 2020
dnfield added a commit that referenced this pull request Jul 24, 2020
…port path" (#2896)

* Revert "[path_provider] Use the application ID in the application support path (#2845)"

This reverts commit 7d4a918.

* bump version to satisfy the machine. Also fix linting issue caught because of changes in this folder.
jarrodcolburn pushed a commit to jarrodcolburn/plugins that referenced this pull request Aug 20, 2020
…port path" (flutter#2896)

* Revert "[path_provider] Use the application ID in the application support path (flutter#2845)"

This reverts commit 7d4a918.

* bump version to satisfy the machine. Also fix linting issue caught because of changes in this folder.
@stuartmorgan
Copy link
Contributor

@robert-ancell Is there a bug tracking re-landing this?

robert-ancell added a commit to robert-ancell/plugins that referenced this pull request Sep 24, 2020
@robert-ancell
Copy link
Contributor Author

@robert-ancell Is there a bug tracking re-landing this?

I'm working on a fixed version in #3077

robert-ancell added a commit to robert-ancell/plugins that referenced this pull request Sep 24, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
…port path" (flutter#2896)

* Revert "[path_provider] Use the application ID in the application support path (flutter#2845)"

This reverts commit 7d4a918.

* bump version to satisfy the machine. Also fix linting issue caught because of changes in this folder.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
…port path" (flutter#2896)

* Revert "[path_provider] Use the application ID in the application support path (flutter#2845)"

This reverts commit 7d4a918.

* bump version to satisfy the machine. Also fix linting issue caught because of changes in this folder.
robert-ancell added a commit to robert-ancell/plugins that referenced this pull request Feb 26, 2021
flutter#2845)

Use the existing executable named directory if it exists, to allow backwards
compatibility to work.
robert-ancell added a commit to robert-ancell/plugins that referenced this pull request Feb 26, 2021
flutter#2845)

Use the existing executable named directory if it exists, to allow backwards
compatibility to work.
robert-ancell added a commit to robert-ancell/plugins that referenced this pull request Oct 31, 2021
flutter#2845)

Use the existing executable named directory if it exists, to allow backwards
compatibility to work.
robert-ancell added a commit to robert-ancell/plugins that referenced this pull request Nov 1, 2021
flutter#2845)

Use the existing executable named directory if it exists, to allow backwards
compatibility to work.
stuartmorgan pushed a commit that referenced this pull request Dec 9, 2021
#2845) (#3077)

Use the existing executable named directory if it exists, to allow backwards
compatibility to work.
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
flutter#2845) (flutter#3077)

Use the existing executable named directory if it exists, to allow backwards
compatibility to work.
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
flutter#2845) (flutter#3077)

Use the existing executable named directory if it exists, to allow backwards
compatibility to work.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants