-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[path_provider] Use the application ID in the application support path #2845
[path_provider] Use the application ID in the application support path #2845
Conversation
1be79ee
to
995b482
Compare
995b482
to
61f9d14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits. We'll need a follow-up once this is landed and published that's a breaking change for path_provider itself to use this version of path_provider_linux.
Normally I would say we need to provide a utility method to allow people to migrate things, but since this is very new and Linux is still a technical preview, I don't think it's going to be necessary. If someone really wants it, it can always be added in a follow-up.
This PR seems to have broken tests in master?
|
…port path" (flutter#2896) * Revert "[path_provider] Use the application ID in the application support path (flutter#2845)" This reverts commit 7d4a918. * bump version to satisfy the machine. Also fix linting issue caught because of changes in this folder.
@robert-ancell Is there a bug tracking re-landing this? |
I'm working on a fixed version in #3077 |
…port path" (flutter#2896) * Revert "[path_provider] Use the application ID in the application support path (flutter#2845)" This reverts commit 7d4a918. * bump version to satisfy the machine. Also fix linting issue caught because of changes in this folder.
…port path" (flutter#2896) * Revert "[path_provider] Use the application ID in the application support path (flutter#2845)" This reverts commit 7d4a918. * bump version to satisfy the machine. Also fix linting issue caught because of changes in this folder.
flutter#2845) Use the existing executable named directory if it exists, to allow backwards compatibility to work.
flutter#2845) Use the existing executable named directory if it exists, to allow backwards compatibility to work.
flutter#2845) Use the existing executable named directory if it exists, to allow backwards compatibility to work.
flutter#2845) Use the existing executable named directory if it exists, to allow backwards compatibility to work.
flutter#2845) (flutter#3077) Use the existing executable named directory if it exists, to allow backwards compatibility to work.
flutter#2845) (flutter#3077) Use the existing executable named directory if it exists, to allow backwards compatibility to work.
Description
Use the application ID in the application support path. The existing code uses the binary name, which is not necessarily unique. Application IDs were recently added to the Linux shell.
Related Issues
flutter/flutter#59234
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?