Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Use the application ID in the application support path (#2845) #3077

Merged
merged 5 commits into from
Dec 9, 2021
Merged

[path_provider] Use the application ID in the application support path (#2845) #3077

merged 5 commits into from
Dec 9, 2021

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Sep 24, 2020 •
edited
Loading

Description

Change getApplicationSupportPath to use the Linux application ID instead of the executable name.

The was landed, then reverted in #2845.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@robert-ancell robert-ancell marked this pull request as draft September 24, 2020 03:44
@robert-ancell robert-ancell mentioned this pull request Sep 24, 2020
Merged
13 tasks
@stuartmorgan
Copy link
Contributor

@robert-ancell Is this something you are still planning to do? It's a breaking change (e.g., for shared_preferences), so the earlier the better, although I think we'll need to make it opt-in at this point since there's been more time for people to start depending on the current behavior.

@robert-ancell
Copy link
Contributor Author

It's something we really should do, though I haven't been looking at it. I'll put it back on my TODO list.

@robert-ancell robert-ancell force-pushed the linux-path-provider-app-id-take2 branch 2 times, most recently from 697e0bf to 6b91be1 Compare February 26, 2021 03:15
@robert-ancell robert-ancell marked this pull request as ready for review February 26, 2021 03:46
@robert-ancell
Copy link
Contributor Author

I've updated this to use the legacy directory name if it exists, and use the new one if not. This should mean existing apps keep working as expected.

@robert-ancell
Copy link
Contributor Author

The test failure seems unrelated to this PR - a trivial PR (#3774) also shows the same failure.

@robert-ancell robert-ancell mentioned this pull request May 6, 2021
Closed
11 tasks
@stuartmorgan stuartmorgan self-requested a review September 2, 2021 14:46
stuartmorgan
stuartmorgan reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you still planning on updating this with tests for the new functionality?

@stuartmorgan
Copy link
Contributor

@robert-ancell Ping on this? I do still think this is something we should do, it just needs the final testing.

@robert-ancell
Copy link
Contributor Author

Are you still planning on updating this with tests for the new functionality?

Yes, will update this next week.

@robert-ancell robert-ancell force-pushed the linux-path-provider-app-id-take2 branch from aacae67 to 2ac7e58 Compare October 31, 2021 23:38
@robert-ancell
Copy link
Contributor Author

Updated now with tests. I've rebased because there have been enough upstream changes to warrant giving it a whole look over again.

@robert-ancell
[path_provider] Use the application ID in the application support path (
dc5f8b9 
flutter#2845)

Use the existing executable named directory if it exists, to allow backwards
compatibility to work.
@robert-ancell robert-ancell force-pushed the linux-path-provider-app-id-take2 branch from 2ac7e58 to dc5f8b9 Compare November 1, 2021 02:12
stuartmorgan
stuartmorgan approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

packages/path_provider/path_provider_linux/lib/src/path_provider_linux.dart Outdated Show resolved Hide resolved
packages/path_provider/path_provider_linux/test/path_provider_linux_test.dart Outdated Show resolved Hide resolved
packages/path_provider/path_provider_linux/lib/src/path_provider_linux.dart Outdated Show resolved Hide resolved
@robert-ancell
Copy link
Contributor Author

@stuartmorgan is the "submit-queue" test failure related to this? Seems to be a video player issue.

@stuartmorgan
Copy link
Contributor

submit-queue is the current status of the tree, to prevent landing PRs into a broken tree; it's never related to the PR itself.

@stuartmorgan stuartmorgan added waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. last mile labels Dec 8, 2021
@stuartmorgan stuartmorgan merged commit 537cc43 into flutter:master Dec 9, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021
@engine-flutter-autoroll
537cc43 [path_provider] Use the application ID in the application sup…
b25a818 
…port path (flutter#2845) (flutter/plugins#3077)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021
@engine-flutter-autoroll
537cc43 [path_provider] Use the application ID in the application sup…
768b519 
…port path (flutter#2845) (flutter/plugins#3077)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021
@engine-flutter-autoroll
537cc43 [path_provider] Use the application ID in the application sup…
7c9ff01 
…port path (flutter#2845) (flutter/plugins#3077)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021
@engine-flutter-autoroll
537cc43 [path_provider] Use the application ID in the application sup…
87af203 
…port path (flutter#2845) (flutter/plugins#3077)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@robert-ancell @amantoux
[path_provider] Use the application ID in the application support path (
b2ff973 
flutter#2845) (flutter#3077)

Use the existing executable named directory if it exists, to allow backwards
compatibility to work.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2021
@engine-flutter-autoroll
537cc43 [path_provider] Use the application ID in the application sup…
8fe5dfa 
…port path (flutter#2845) (flutter/plugins#3077)
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@robert-ancell @KyleFin
[path_provider] Use the application ID in the application support path (
8d1f34a 
flutter#2845) (flutter#3077)

Use the existing executable named directory if it exists, to allow backwards
compatibility to work.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@matthew-carroll matthew-carroll Awaiting requested review from matthew-carroll

Assignees
No one assigned
Labels
cla: yes p: path_provider platform-linux waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-ancell @stuartmorgan @googlebot