libsubprocess: ensure bulk-exec output is terminated #6368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: garbage appears in the logs when the bulkexec imp-kill generates output.
Since bulk-exec always uses unbuffered reads for performance, the output buffers returned by
flux_subprocess_read()
are not guaranteed to be NULL terminated.Use
"%.*s"
instead of"%s"
in the log format string for:on_output()
handleron_output()
handlerFixes #6366