Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsubprocess: ensure bulk-exec output is terminated #6368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libsubprocess: ensure bulk-exec output is terminated #6368

wants to merge 1 commit into from

Commits on Oct 12, 2024

  1. libsubprocess: ensure bulk-exec output is terminated 

    Problem: garbage appears in the logs when the bulkexec imp-kill
generates output.

Since bulk-exec always uses unbuffered reads for performance, the
output buffers returned by flux_subprocess_read() are not guaranteed
to be NULL terminated.

Use "%.*s" instead of "%s" in the log format string for:
- the imp kill on_output() handler
- the fallback in case a user doesn't define an on_output() handler

Fixes flux-framework#6366
    @garlick
    garlick committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    df77f35 View commit details
    Browse the repository at this point in the history