Cleanup FilterGroups README #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the FilterGroups README to list properties in tables, consistent with most other component documentation in FOLIO, and increasing readability.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zburke
reviewed
Jan 4, 2024
bvsharp
approved these changes
Jan 5, 2024
zburke
approved these changes
Jan 5, 2024
|
github-actions bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Cleanup FilterGroups README This updates the FilterGroups README to list properties in tables, consistent with most other component documentation in FOLIO, and increasing readability. * FilterControlGroup label must be a string, due to ARIA restrictions * Update label prop in FilterGroups to be consistent with FilterControlGroup * Add undocumented props --------- Co-authored-by: John Coburn <jcoburn@ebsco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the FilterGroups README to list properties in tables, consistent with most other component documentation in FOLIO, and increasing readability. It also restricts the
prop-typesoflabelto astring, which is required due to its usage as an ARIA label. Finally, it also adds a few undocumented props (one of which is required!)