[UILISTS-91] Create typings for ui-lists components usage #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| * value and displayed on the page), or an object enabling more customization. | ||
| */ | ||
| export type FilterGroupsConfigValue = | ||
| | string |
There was a problem hiding this comment.
This is a new syntax thing for me... Does the leading | just get ignored or does it have some semantics beyond just making the formatting look nice?
There was a problem hiding this comment.
Yep, the leading one gets ignored specifically to make things like this line up pretty
Comment on lines
+20
to
+21
| /** @deprecated use dismissible instead */ | ||
| dismissable?: true; |
mweaver-ebsco
approved these changes
Jan 5, 2024
ncovercash
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira UILISTS-91
There is improper usage of
FilterGroupsandConfirmationModalinui-listswhich will break if this is merged. These issues should be fixed inui-listsand merged with/before. See UILISTS-95Adds
anyand marked@deprecatedrg LegacyPopover ./node_modules/@folio/*shows that this component is not used anymore. Maybe we should remove it entirely?stripes-componentsitself...Improves
buttonStyletypings for easier reusePopperpropsPopperpropsPopperpropsPopperpropsBonus PRs made as part of this