Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Popover children prop as required #2196

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Document Popover children prop as required #2196

merged 4 commits into from
Jan 5, 2024

Conversation

ncovercash
Copy link
Member

This prop is required, as denoted by the component's prop-types. The README should denote this requirement.

@ncovercash
Document Popover children prop as required
4fb6c75 
This prop is required, as denoted by the component's prop-types.  The README should denote this requirement.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 631f5fd. ± Comparison against base commit 988d17a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

BigTest Unit Test Statistics

       1 files  ±0         1 suites  ±0   11s ⏱️ ±0s
1 416 tests ±0  1 395 ✔️ ±0  21 💤 ±0  0 ❌ ±0 
1 419 runs  ±0  1 398 ✔️ ±0  21 💤 ±0  0 ❌ ±0 

Results for commit 631f5fd. ± Comparison against base commit 988d17a.

♻️ This comment has been updated with latest results.

@ncovercash ncovercash mentioned this pull request Jan 4, 2024
Merged
zburke
zburke reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| Yes | or | | Yes |? I don't think Yes makes sense as a default value.

@ncovercash
Copy link
Member Author

| Yes | or | | Yes |? I don't think Yes makes sense as a default value.

oops, the lack of a side vertical line tripped me up.

@ncovercash ncovercash requested a review from zburke January 4, 2024 21:52
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ncovercash ncovercash merged commit 3454432 into master Jan 5, 2024
6 checks passed
@ncovercash ncovercash deleted the popover-readme-fix branch January 5, 2024 14:02
github-actions bot pushed a commit that referenced this pull request Jan 5, 2024
@ncovercash @JohnC-80
Document Popover children prop as required (#2196)
9ca4a25 
* Document Popover children prop as required

This prop is required, as denoted by the component's prop-types.  The README should denote this requirement.

* oops

---------

Co-authored-by: John Coburn <jcoburn@ebsco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zburke zburke zburke approved these changes

@bvsharp bvsharp bvsharp approved these changes

@JohnC-80 JohnC-80 Awaiting requested review from JohnC-80

@mweaver-ebsco mweaver-ebsco Awaiting requested review from mweaver-ebsco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncovercash @zburke @bvsharp @JohnC-80