Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RadioButtonGroup prop types #2203

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Update RadioButtonGroup prop types #2203

merged 5 commits into from
Jan 5, 2024

Conversation

ncovercash
Copy link
Member

@ncovercash ncovercash commented Jan 4, 2024 •
edited
Loading

warning and error can be nodes, too!

Even though PropTypes.node contains PropTypes.node, I listed both for consistency with the others.

✨ bonus ✨

  • added more examples to the README

@ncovercash ncovercash marked this pull request as ready for review January 4, 2024 23:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit b5bdafe. ± Comparison against base commit 516877c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

BigTest Unit Test Statistics

       1 files  ±0         1 suites  ±0   11s ⏱️ ±0s
1 416 tests ±0  1 395 ✔️ ±0  21 💤 ±0  0 ❌ ±0 
1 419 runs  ±0  1 398 ✔️ ±0  21 💤 ±0  0 ❌ ±0 

Results for commit b5bdafe. ± Comparison against base commit 516877c.

♻️ This comment has been updated with latest results.

@ncovercash ncovercash mentioned this pull request Jan 5, 2024
Merged
zburke
zburke approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, examples!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ncovercash ncovercash merged commit c1faca7 into master Jan 5, 2024
6 checks passed
@ncovercash ncovercash deleted the radiobuttongroup-prop-types branch January 5, 2024 16:49
github-actions bot pushed a commit that referenced this pull request Jan 5, 2024
@ncovercash
Update RadioButtonGroup prop types (#2203)
cc161bf 
* Update RadioButtonGroup prop types

* Update prop types

* Update readme.md

* Update readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zburke zburke zburke approved these changes

@bvsharp bvsharp bvsharp approved these changes

@JohnC-80 JohnC-80 Awaiting requested review from JohnC-80

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncovercash @zburke @bvsharp