Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customImage parameter #150

Closed
webbertakken opened this issue Sep 17, 2020 · 0 comments · Fixed by #151
Closed

Add customImage parameter #150

webbertakken opened this issue Sep 17, 2020 · 0 comments · Fixed by #151
Labels
good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/

Comments

@webbertakken
Copy link
Member

Context

At the time of writing, some images from upstream are not working.

Suggested solution

Add a parameter to Unity Builder called customImage that accepts any docker image (and thus overrides unityVersion behaviour), so that custom hashes can be used.

This would solve the faulty android images problem short term, and add a valuable feature for the long term as well.

Considered alternatives

We've been trying to get these android images going again by republishing the correct NDK, SDK etc. Follow main thread and separate PoC to help in our current attempts.
@webbertakken webbertakken added good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/ labels Sep 17, 2020
@webbertakken webbertakken mentioned this issue Sep 18, 2020
Merged
3 tasks
webbertakken pushed a commit that referenced this issue Sep 18, 2020
@caiusno1
Solution proposal to Issue Add customImage parameter #150 (#151)
6a53a9e 
* add customImage attribute

* add one more test for input passing && check for customImage == ''
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solution proposal to Issue Add customImage parameter #150
1 participant
@webbertakken