Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution proposal to Issue Add customImage parameter #150 #151

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Solution proposal to Issue Add customImage parameter #150 #151

merged 2 commits into from
Sep 18, 2020

Conversation

caiusno1
Copy link
Contributor

@caiusno1 caiusno1 commented Sep 18, 2020

Changes

  • Add customImage attribute and related tests

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Remarks

This is my first attempt to commit to an open source project so there might be something missing. I am not sure how to test whether the action now works with that new attribute. I appreciate any hint :)

Fixes #150

@webbertakken
Copy link
Member

Great! Please don't worry about the K8s jobs, they're not required for your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add customImage parameter
2 participants