-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(publish): clear built files before building package and packing (#…
…12516) * feat(publish): clear built files before building package and packing * Add some feedback message if dev doesn't confirm file deletion
- Loading branch information
Showing
3 changed files
with
158 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| const ignore = require(`ignore`) | ||
| const fs = require(`fs-extra`) | ||
| const glob = require(`glob`) | ||
| const yargs = require(`yargs`) | ||
| const chalk = require(`chalk`) | ||
| const PromptUtilities = require(`@lerna/prompt`) | ||
| const _ = require(`lodash`) | ||
| const path = require(`path`) | ||
| const { execSync } = require(`child_process`) | ||
|
|
||
| let argv = yargs | ||
| .option(`dry-run`, { | ||
| default: false, | ||
| describe: `Don't delete files - just show what would be deleted`, | ||
| }) | ||
| .option(`verbose`, { | ||
| default: false, | ||
| describe: `Show files that would be bundled and mark files that will be deleted`, | ||
| }) | ||
| .option(`force`, { | ||
| default: false, | ||
| describe: `Force deletion of file without prompting user to confirm`, | ||
| }).argv | ||
|
|
||
| const verbose = argv[`dry-run`] || argv[`verbose`] || !argv[`force`] | ||
|
|
||
| const buildIgnoreArray = str => | ||
| str | ||
| .split(`\n`) | ||
| .filter(line => { | ||
| // skip empty lines and comments | ||
| if (!line || line[0] === `#`) { | ||
| return false | ||
| } | ||
|
|
||
| return true | ||
| }) | ||
| .reduce((acc, item) => { | ||
| acc.push(item) | ||
|
|
||
| // add "<directory>/**" glob as ignore package need that to | ||
| // properly ignore entries like "node_modules" | ||
| if (!/\*\*$/.test(item)) { | ||
| acc.push(`${item}/**`) | ||
| } | ||
| return acc | ||
| }, []) | ||
|
|
||
| const getListOfFilesToClear = ({ location, name }) => { | ||
| if (verbose) { | ||
| console.log(`Files that will be packed for ${chalk.bold(name)}:`) | ||
| } | ||
|
|
||
| let gitignore = [] | ||
| try { | ||
| gitignore = buildIgnoreArray( | ||
| fs.readFileSync(path.join(location, `.gitignore`), `utf-8`) | ||
| ) | ||
| } catch { | ||
| // not all packages have .gitignore - see gatsby-plugin-no-sourcemap | ||
| } finally { | ||
| const notTrackedFiles = execSync( | ||
| `git ls-files --others --exclude-standard`, | ||
| { | ||
| cwd: location, | ||
| } | ||
| ) | ||
| .toString() | ||
| .split(`\n`) | ||
|
|
||
| gitignore = gitignore.concat(notTrackedFiles) | ||
|
|
||
| // we need main file - for now hardcode index | ||
| // that is used in most of our packages | ||
| // it should actually be in each package .gitignore | ||
| gitignore.push(`!/index.js`) | ||
| } | ||
|
|
||
| let npmignore = [] | ||
| try { | ||
| npmignore = buildIgnoreArray( | ||
| fs.readFileSync(path.join(location, `.npmignore`), `utf-8`) | ||
| ) | ||
| } catch { | ||
| // not all packages have .npmignore - see gatsby-plugin-no-sourcemap | ||
| } finally { | ||
| npmignore = npmignore.concat([`node_modules/**`]) | ||
| } | ||
|
|
||
| const result = glob.sync(`**/*`, { | ||
| nodir: true, | ||
| ignore: npmignore, | ||
| cwd: location, | ||
| }) | ||
|
|
||
| const ig = ignore().add(gitignore) | ||
|
|
||
| const filesToDelete = result | ||
| .filter(file => { | ||
| const willBeDeleted = ig.ignores(file) | ||
| if (verbose) { | ||
| console.log( | ||
| `[ ${willBeDeleted ? chalk.red(`DEL`) : chalk.green(` - `)} ] ${file}` | ||
| ) | ||
| } | ||
|
|
||
| return willBeDeleted | ||
| }) | ||
| .map(file => path.join(location, file)) | ||
|
|
||
| return filesToDelete | ||
| } | ||
|
|
||
| const run = async () => { | ||
| try { | ||
| const changed = JSON.parse( | ||
| execSync( | ||
| `node_modules/.bin/lerna changed --json --loglevel=silent` | ||
| ).toString() | ||
| ) | ||
| const filesToDelete = _.flatten(changed.map(getListOfFilesToClear)) | ||
|
|
||
| if (!argv[`dry-run`] && filesToDelete.length > 0) { | ||
| if ( | ||
| argv[`force`] || | ||
| (await PromptUtilities.confirm( | ||
| `Are you sure you want to delete those files?` | ||
| )) | ||
| ) { | ||
| filesToDelete.forEach(file => { | ||
| fs.removeSync(file) | ||
| }) | ||
| } else { | ||
| console.log( | ||
| `${chalk.red( | ||
| `Stopping publish` | ||
| )}: there are files that need to be cleared.\n\nIf this is a bug in check script and everything is fine, run:\n\n${chalk.green( | ||
| `yarn lerna publish` | ||
| )}\n\ndirectly to skip checks (and hopefully apply changes to clear-package-dir script to fix it).` | ||
| ) | ||
| process.exit(1) | ||
| } | ||
| } | ||
| } catch { | ||
| // if no packages are marked are changed, lerna will exit with non-zero | ||
| } | ||
| } | ||
|
|
||
| run() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters