feat(publish): clear built files before building package and packing #12516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
reviewed
Mar 12, 2019
|
I'll close this is this has potential for problems and comment what I think is more straight forward solution in issue |
|
Argh, my bad, solution I thought of is not really possible (just output built files to |
|
Any updates on this @pieh? |
wardpeet
added
the
status: awaiting author response
|
No updates on this yet, let me sync this branch and address Dustin's comments. And should be good to go I think |
pieh
force-pushed
the
clear-packages-before-publishing
branch
2 times, most recently
from
df88676
to
10b0571
Compare
|
All right, updated the PR and is ready for review |
pieh
added
status: awaiting reviewer response
freiksenet
approved these changes
Jun 24, 2019
freiksenet
added
bot: merge on green
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
Jul 17, 2019
…atsbyjs#12516) * feat(publish): clear built files before building package and packing * Add some feedback message if dev doesn't confirm file deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds extra step before publishing to clear any previously built files.
Initially I added prompt to confirm file deletion just in case script need to be adjusted and problems can be caught
Example output:
https://gist.github.com/pieh/1ebb938eb300aaac882491bd94a3506f
Btw - this also catch some weirdness in our package build scripts - like
graphql-skip-limitpacks bothsrcanddist, or testfixtures being packed ingatsby-codemodsCloses #12491