fix(gatsby-plugin-netlify): add page-data & app-data to preload list #21552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this config option affect this? https://www.gatsbyjs.org/docs/browser-apis/#disableCorePrefetching |
pieh
reviewed
Feb 21, 2020
|
Oh damn I closed this one |
wardpeet
force-pushed
the
fix/netlify-preload-header
branch
from
4c3db33
to
e177f4a
Compare
|
I removed the no-push changes I made earlier as they are not needed and make this PR more complex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve netlify headers by adding page-data & app-data to HTTP preload, this will let the browser start the download sooner.
It works :) You can see the difference in these snapshots, the important part is when our images start to load. As these are our indicators when our js is being executed.
Mobile 4G:
https://webpagetest.org/video/compare.php?tests=200224_T2_3323f0e578a9efc861f44ddcd2bd4250%2C200224_F2_68e33c289ced2e9c826d9617f4e8f18a&thumbSize=200&ival=100&end=full
Desktop 4G:
https://webpagetest.org/video/compare.php?tests=200224_DW_f3516a43d45095def0edab713dd22f73%2C200224_8C_75beb58838faed97672a522b7b21458b&thumbSize=200&ival=100&end=full
Desktop fast internet:
https://webpagetest.org/video/compare.php?tests=200224_MV_a147387f2c846b1685f05bc407ef5ac7%2C200224_MT_d1b109458f8135fde63248ed82b20f1a&thumbSize=200&ival=100&end=full