Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-netlify): add page-data & app-data to preload list #21552

Merged
merged 4 commits into from
Feb 25, 2020
Merged

fix(gatsby-plugin-netlify): add page-data & app-data to preload list #21552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
330dcb1
fix(gatsby-plugin-netlify): add page-data & app-data to preload list
wardpeet Feb 18, 2020
4ee87f6
Make sure app-data or page-data exists before adding
wardpeet Feb 24, 2020
e177f4a
removen no-push, no need to make it complex
wardpeet Feb 24, 2020
d028a6b
remove app-data from manifest test
wardpeet Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 86 additions & 34 deletions packages/gatsby-plugin-netlify/src/__tests__/__snapshots__/build-headers-program.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ X-Frame-Options
Cache-Control: public, max-age=31536000, immutable
/component---src-pages-index-js-0bdd01c77ee09ef0224c.js
Cache-Control: public, max-age=31536000, immutable
/pages-manifest-ab11f09e0ca7ecd3b43e.js
Cache-Control: public, max-age=31536000, immutable
/webpack-runtime-acaa8994f1f704475e21.js
Cache-Control: public, max-age=31536000, immutable
/styles.1025963f4f2ec7abbad4.css
Expand All @@ -39,42 +37,56 @@ X-Frame-Options
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </component---node-modules-gatsby-plugin-offline-app-shell-js-78f9e4dea04737fa062d.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/offline-plugin-app-shell-fallback/page-data.json>; rel=preload; as=fetch; crossorigin
/hi-folks/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/hi-folks/page-data.json>; rel=preload; as=fetch; crossorigin
/my-second-post/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/my-second-post/page-data.json>; rel=preload; as=fetch; crossorigin
/hello-world/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/hello-world/page-data.json>; rel=preload; as=fetch; crossorigin
/404/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-404-js-53e6c51a5a7e73090f50.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/404/page-data.json>; rel=preload; as=fetch; crossorigin
/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-index-js-0bdd01c77ee09ef0224c.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/index/page-data.json>; rel=preload; as=fetch; crossorigin
/404.html
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-404-js-53e6c51a5a7e73090f50.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/404.html/page-data.json>; rel=preload; as=fetch; crossorigin
"
`;

Expand All @@ -96,8 +108,6 @@ exports[`build-headers-program with caching headers 1`] = `
Cache-Control: public, max-age=31536000, immutable
/component---src-pages-index-js-0bdd01c77ee09ef0224c.js
Cache-Control: public, max-age=31536000, immutable
/pages-manifest-ab11f09e0ca7ecd3b43e.js
Cache-Control: public, max-age=31536000, immutable
/webpack-runtime-acaa8994f1f704475e21.js
Cache-Control: public, max-age=31536000, immutable
/styles.1025963f4f2ec7abbad4.css
Expand All @@ -115,56 +125,67 @@ exports[`build-headers-program with caching headers 1`] = `
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </component---node-modules-gatsby-plugin-offline-app-shell-js-78f9e4dea04737fa062d.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/offline-plugin-app-shell-fallback/page-data.json>; rel=preload; as=fetch; crossorigin
/hi-folks/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/hi-folks/page-data.json>; rel=preload; as=fetch; crossorigin
/my-second-post/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/my-second-post/page-data.json>; rel=preload; as=fetch; crossorigin
/hello-world/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/hello-world/page-data.json>; rel=preload; as=fetch; crossorigin
/404/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-404-js-53e6c51a5a7e73090f50.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/404/page-data.json>; rel=preload; as=fetch; crossorigin
/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-index-js-0bdd01c77ee09ef0224c.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/index/page-data.json>; rel=preload; as=fetch; crossorigin
/404.html
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-404-js-53e6c51a5a7e73090f50.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/404.html/page-data.json>; rel=preload; as=fetch; crossorigin
"
`;

exports[`build-headers-program with security headers 1`] = `
exports[`build-headers-program with manifest['pages-manifest'] 1`] = `
"## Created with gatsby-plugin-netlify

/*
X-Frame-Options: ALLOW-FROM https://app.storyblok.com/
X-Frame-Options: DENY
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
Referrer-Policy: same-origin
Content-Security-Policy: frame-ancestors 'self' https://*.storyblok.com/
/hello
X-Frame-Options: SAMEORIGIN
/component---node-modules-gatsby-plugin-offline-app-shell-js-78f9e4dea04737fa062d.js
Cache-Control: public, max-age=31536000, immutable
/0-0180cd94ef2497ac7db8.js
Expand Down Expand Up @@ -233,128 +254,159 @@ exports[`build-headers-program with security headers 1`] = `
"
`;

exports[`build-headers-program without caching headers 1`] = `
exports[`build-headers-program with security headers 1`] = `
"## Created with gatsby-plugin-netlify

/*
X-Frame-Options: DENY
X-Frame-Options: ALLOW-FROM https://app.storyblok.com/
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
Referrer-Policy: same-origin
Content-Security-Policy: frame-ancestors 'self' https://*.storyblok.com/
/hello
X-Frame-Options: SAMEORIGIN
/component---node-modules-gatsby-plugin-offline-app-shell-js-78f9e4dea04737fa062d.js
Cache-Control: public, max-age=31536000, immutable
/0-0180cd94ef2497ac7db8.js
Cache-Control: public, max-age=31536000, immutable
/component---src-templates-blog-post-js-517987eae96e75cddbe7.js
Cache-Control: public, max-age=31536000, immutable
/component---src-pages-404-js-53e6c51a5a7e73090f50.js
Cache-Control: public, max-age=31536000, immutable
/component---src-pages-index-js-0bdd01c77ee09ef0224c.js
Cache-Control: public, max-age=31536000, immutable
/webpack-runtime-acaa8994f1f704475e21.js
Cache-Control: public, max-age=31536000, immutable
/styles.1025963f4f2ec7abbad4.css
Cache-Control: public, max-age=31536000, immutable
/styles-565f081c8374bbda155f.js
Cache-Control: public, max-age=31536000, immutable
/app-f33c13590352da20930f.js
Cache-Control: public, max-age=31536000, immutable
/static/*
Cache-Control: public, max-age=31536000, immutable
/sw.js
Cache-Control: no-cache
/offline-plugin-app-shell-fallback/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </component---node-modules-gatsby-plugin-offline-app-shell-js-78f9e4dea04737fa062d.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/offline-plugin-app-shell-fallback/page-data.json>; rel=preload; as=fetch; crossorigin
/hi-folks/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/hi-folks/page-data.json>; rel=preload; as=fetch; crossorigin
/my-second-post/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/my-second-post/page-data.json>; rel=preload; as=fetch; crossorigin
/hello-world/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/hello-world/page-data.json>; rel=preload; as=fetch; crossorigin
/404/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-404-js-53e6c51a5a7e73090f50.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/404/page-data.json>; rel=preload; as=fetch; crossorigin
/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-index-js-0bdd01c77ee09ef0224c.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/index/page-data.json>; rel=preload; as=fetch; crossorigin
/404.html
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-404-js-53e6c51a5a7e73090f50.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/404.html/page-data.json>; rel=preload; as=fetch; crossorigin
"
`;

exports[`build-headers-program without manifest['pages-manifest'] 1`] = `
exports[`build-headers-program without caching headers 1`] = `
"## Created with gatsby-plugin-netlify

/*
X-Frame-Options: DENY
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
Referrer-Policy: same-origin
/component---node-modules-gatsby-plugin-offline-app-shell-js-78f9e4dea04737fa062d.js
Cache-Control: public, max-age=31536000, immutable
/0-0180cd94ef2497ac7db8.js
Cache-Control: public, max-age=31536000, immutable
/component---src-templates-blog-post-js-517987eae96e75cddbe7.js
Cache-Control: public, max-age=31536000, immutable
/component---src-pages-404-js-53e6c51a5a7e73090f50.js
Cache-Control: public, max-age=31536000, immutable
/component---src-pages-index-js-0bdd01c77ee09ef0224c.js
Cache-Control: public, max-age=31536000, immutable
/webpack-runtime-acaa8994f1f704475e21.js
Cache-Control: public, max-age=31536000, immutable
/styles.1025963f4f2ec7abbad4.css
Cache-Control: public, max-age=31536000, immutable
/styles-565f081c8374bbda155f.js
Cache-Control: public, max-age=31536000, immutable
/app-f33c13590352da20930f.js
Cache-Control: public, max-age=31536000, immutable
/static/*
Cache-Control: public, max-age=31536000, immutable
/sw.js
Cache-Control: no-cache
/offline-plugin-app-shell-fallback/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </component---node-modules-gatsby-plugin-offline-app-shell-js-78f9e4dea04737fa062d.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/offline-plugin-app-shell-fallback/page-data.json>; rel=preload; as=fetch; crossorigin
/hi-folks/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/hi-folks/page-data.json>; rel=preload; as=fetch; crossorigin
/my-second-post/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/my-second-post/page-data.json>; rel=preload; as=fetch; crossorigin
/hello-world/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-templates-blog-post-js-517987eae96e75cddbe7.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/hello-world/page-data.json>; rel=preload; as=fetch; crossorigin
/404/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-404-js-53e6c51a5a7e73090f50.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/404/page-data.json>; rel=preload; as=fetch; crossorigin
/
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-index-js-0bdd01c77ee09ef0224c.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/index/page-data.json>; rel=preload; as=fetch; crossorigin
/404.html
Link: </webpack-runtime-acaa8994f1f704475e21.js>; rel=preload; as=script
Link: </styles-565f081c8374bbda155f.js>; rel=preload; as=script
Link: </app-f33c13590352da20930f.js>; rel=preload; as=script
Link: </0-0180cd94ef2497ac7db8.js>; rel=preload; as=script
Link: </component---src-pages-404-js-53e6c51a5a7e73090f50.js>; rel=preload; as=script
Link: </page-data/app-data.json>; rel=preload; as=fetch; crossorigin
Link: </page-data/404.html/page-data.json>; rel=preload; as=fetch; crossorigin
"
`;
Loading