Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignition.dsl: colcon for ign-tools on windows #537

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Conversation

scpeters
Copy link
Contributor

Part of #412, similar to #536.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Contributor Author

scpeters commented Oct 16, 2021

after this, need to update:

@scpeters
Copy link
Contributor Author

testing:

Added items:
    GeneratedJob{name='ign_tools-pr-win'}
    GeneratedJob{name='ign_tools-ign-1-win'}
    GeneratedJob{name='ign_tools-ci-win'}
...
Unreferenced items:
    GeneratedJob{name='ignition_tools-ci-ign-tools1-windows7-amd64'}
    GeneratedJob{name='ignition_tools-ci-main-windows7-amd64'}
    GeneratedJob{name='ignition_tools-ci-pr_any-windows7-amd64'}
Disabled items:
    GeneratedJob{name='ignition_tools-ci-ign-tools1-windows7-amd64'}
    GeneratedJob{name='ignition_tools-ci-main-windows7-amd64'}
    GeneratedJob{name='ignition_tools-ci-pr_any-windows7-amd64'}

@scpeters
Copy link
Contributor Author

ok, I think there is a bug in our build script because this build failed but is marked as a success

CMake Error in src/CMakeLists.txt:
  Evaluation file to be written multiple times with different content.  This
  is generally caused by the content evaluating the configuration type,
  language, or location of object files:

   C:/Jenkins/workspace/ign_tools-ign-1-win/ws/build/ignition-tools/ign.rb


CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING


CMake Generate step failed.  Build files cannot be regenerated correctly.
---
Failed   <<< ignition-tools	[ Exited with code 1 ]

Summary: 0 packages finished [16.9s]
  1 package failed: ignition-tools
  1 package had stderr output: ignition-tools
Failed in windows_library with error #1.
# END SECTION

maybe it's related to ENABLE_TESTS == false?

@scpeters
Copy link
Contributor Author

the colcon build should be fixed by gazebosim/gz-tools#65, but we should figure out why it currently is not marked as a failure

@scpeters
Copy link
Contributor Author

the colcon build should be fixed by ignitionrobotics/ign-tools#65, but we should figure out why it currently is not marked as a failure

I'll open an issue for this so we can expedite the merging of this PR

@scpeters
Copy link
Contributor Author

the colcon build should be fixed by ignitionrobotics/ign-tools#65, but we should figure out why it currently is not marked as a failure

I'll open an issue for this so we can expedite the merging of this PR

#538

@scpeters
Copy link
Contributor Author

a test has been added in gazebosim/gz-tools#67, so I've changed the logic to expect tests for ign-tools in b11aaa7

@scpeters
Copy link
Contributor Author

a test has been added in ignitionrobotics/ign-tools#67, so I've changed the logic to expect tests for ign-tools in b11aaa7

testing:

Build Status https://build.osrfoundation.org/job/_dsl_ignition/1212/

@scpeters scpeters requested a review from azeey October 22, 2021 23:02
@scpeters scpeters merged commit d83d624 into master Oct 25, 2021
@scpeters scpeters deleted the scpeters/colcon_tools branch October 25, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants